Sign upLogin

DeFiCh/jellyfish

View on GitHub
Star

Showing 358 of 388 total issues

Function createDeFiTx has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async createDeFiTx (
    opDeFiTx: OP_DEFI_TX,
    changeScript: Script,
    outValue: BigNumber = new BigNumber('0'),
    utxos: Prevout[] = []
Severity: Minor
Found in packages/jellyfish-transaction-builder/src/txn/txn_builder.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    beforeAll(async () => {
  const app = await Test.createTestingModule({
    imports: [MemoryDatabaseModule],
    providers: [ScriptActivityMapper]
  }).compile()
    Severity: Major
    Found in apps/whale-api/src/module.model/script.activity.spec.ts and 1 other location - About 1 hr to fix
    apps/whale-api/src/module.model/block.spec.ts on lines 11..19

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      getScript (): Script {
    if (!this.valid) {
      this.validate()
    }
    Severity: Major
    Found in packages/jellyfish-address/src/p2wpkh.ts and 1 other location - About 1 hr to fix
    packages/jellyfish-address/src/p2wsh.ts on lines 31..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      getScript (): Script {
    if (!this.valid) {
      this.validate()
    }
    Severity: Major
    Found in packages/jellyfish-address/src/p2wsh.ts and 1 other location - About 1 hr to fix
    packages/jellyfish-address/src/p2wpkh.ts on lines 35..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    beforeAll(async () => {
  const app = await Test.createTestingModule({
    imports: [MemoryDatabaseModule],
    providers: [BlockMapper]
  }).compile()
    Severity: Major
    Found in apps/whale-api/src/module.model/block.spec.ts and 1 other location - About 1 hr to fix
    apps/whale-api/src/module.model/script.activity.spec.ts on lines 11..19

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function computePathsBetweenTokens has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async computePathsBetweenTokens (
    fromTokenId: string,
    toTokenId: string
  ): Promise<SwapPathPoolPair[][]> {
    const poolPairPaths: SwapPathPoolPair[][] = []
    Severity: Minor
    Found in apps/whale-api/src/module.api/poolswap.pathfinding.service.ts - About 1 hr to fix

      Function Home has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function Home (): JSX.Element {
  const siteConfig = useDocusaurusContext().siteConfig

  return (
    <Layout description={siteConfig.tagline}>
      Severity: Minor
      Found in website/src/pages/index.tsx - About 1 hr to fix

        Function indexTransaction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async indexTransaction (block: RawBlock, transaction: DfTxTransaction<UpdateOracle>): Promise<void> {
    const txn = transaction.txn
    const data = transaction.dftx.data
    await this.oracleMapper.put({
      id: data.oracleId,
        Severity: Minor
        Found in apps/whale-api/src/module.indexer/model/dftx/update.oracle.ts - About 1 hr to fix

          Function getGovernanceProposalVotes has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async getGovernanceProposalVotes (
    query: PaginationQuery = {
      size: 30
    },
    id: string,
          Severity: Minor
          Found in apps/whale-api/src/module.api/governance.service.ts - About 1 hr to fix

            Function list has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              list (): CreateLoanScheme[] {
    return [
      {
        id: 'MIN150',
        interestRate: new BigNumber('5'),
            Severity: Minor
            Found in apps/playground-api/src/setups/setup.loan.scheme.ts - About 1 hr to fix

              Function list has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                list (): SetLoanToken[] {
    return [
      {
        symbol: 'DUSD',
        name: 'Decentralized USD',
              Severity: Minor
              Found in apps/playground-api/src/setups/setup.loan.token.ts - About 1 hr to fix

                Function createVoc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                  async createVoc (createVoc: CreateVoc, changeScript: Script): Promise<TransactionSegWit> {
    if (!createVoc.nAmount.isEqualTo(new BigNumber(0))) {
      throw new TxnBuilderError(TxnBuilderErrorType.INVALID_VOC_AMOUNT,
        'CreateVoc amount should be 0'
      )
                Severity: Minor
                Found in packages/jellyfish-transaction-builder/src/txn/txn_builder_governance.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  async query (txid: string, limit: number, gt?: string): Promise<TransactionVin[]> {
    return await this.database.query(TransactionVinMapping.index.txid_id, {
      partitionKey: txid,
      limit: limit,
      order: SortOrder.ASC,
                Severity: Major
                Found in apps/whale-api/src/module.model/transaction.vin.ts and 1 other location - About 1 hr to fix
                apps/whale-api/src/module.model/transaction.vout.ts on lines 33..40

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  async query (txid: string, limit: number, gt?: string): Promise<TransactionVout[]> {
    return await this.database.query(TransactionVoutMapping.index.txid_n, {
      partitionKey: txid,
      limit: limit,
      order: SortOrder.ASC,
                Severity: Major
                Found in apps/whale-api/src/module.model/transaction.vout.ts and 1 other location - About 1 hr to fix
                apps/whale-api/src/module.model/transaction.vin.ts on lines 32..39

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export class CResignMasternode extends ComposableBuffer<ResignMasternode> {
  static OP_CODE = 0x52 // 'R'
  static OP_NAME = 'OP_DEFI_TX_RESIGN_MASTER_NODE'

  composers (cmn: ResignMasternode): BufferComposer[] {
                Severity: Major
                Found in packages/jellyfish-transaction/src/script/dftx/dftx_masternode.ts and 1 other location - About 1 hr to fix
                packages/jellyfish-transaction/src/script/dftx/dftx_icxorderbook.ts on lines 198..207

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export class CICXCloseOffer extends ComposableBuffer<ICXCloseOffer> {
  static OP_CODE = 0x37 // '7'
  static OP_NAME = 'OP_DEFI_TX_ICX_CLOSE_OFFER'

  composers (co: ICXCloseOffer): BufferComposer[] {
                Severity: Major
                Found in packages/jellyfish-transaction/src/script/dftx/dftx_icxorderbook.ts and 1 other location - About 1 hr to fix
                packages/jellyfish-transaction/src/script/dftx/dftx_masternode.ts on lines 52..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function catchUp has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  private async catchUp (): Promise<void> {
    const lastBlock = await this.getCrawledTip()
    const nextBlockHeight = lastBlock === undefined ? 0 : lastBlock.data.height + 1
    const nextBlock = await this.getBlock(nextBlockHeight)
                Severity: Minor
                Found in packages/rich-list-core/src/RichListCore.ts - About 1 hr to fix

                  Function createVoc has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    async createVoc (createVoc: CreateVoc, changeScript: Script): Promise<TransactionSegWit> {
    if (!createVoc.nAmount.isEqualTo(new BigNumber(0))) {
      throw new TxnBuilderError(TxnBuilderErrorType.INVALID_VOC_AMOUNT,
        'CreateVoc amount should be 0'
      )
                  Severity: Minor
                  Found in packages/jellyfish-transaction-builder/src/txn/txn_builder_governance.ts - About 1 hr to fix

                    Function list has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      list (): Array<Record<string, any>> {
    return [
      {
        ATTRIBUTES: {
          // dfi pay dtoken
                    Severity: Minor
                    Found in apps/playground-api/src/setups/setup.gov.ts - About 1 hr to fix

                      Function dump has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        async dump (): Promise<boolean> {
    let id = 0
    const maxSize = 500_000
    const dir = path.join(process.cwd(), 'dump')
    if (!fs.existsSync(dir)) {
                      Severity: Minor
                      Found in apps/whale-api/src/module.database/provider.level/level.database.ts - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language