Sign upLogin

DeFiCh/wallet

View on GitHub
Star

Showing 335 of 335 total issues

File CompositeSwapScreen.tsx has 1156 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { Platform, ScrollView, TextInput, View } from "react-native";
import { useSelector } from "react-redux";
import { Controller, useForm } from "react-hook-form";
import BigNumber from "bignumber.js";
Severity: Major
Found in mobile-app/app/screens/AppNavigator/screens/Dex/CompositeSwap/CompositeSwapScreen.tsx - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function useResultingCollateralizationRatioByCollateral({
  collateralValue,
  collateralRatio,
  minCollateralRatio,
  totalLoanAmount,
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Loans/hooks/CollateralizationRatioV2.ts and 1 other location - About 2 days to fix
    mobile-app/app/screens/AppNavigator/screens/Loans/hooks/CollateralizationRatio.ts on lines 70..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 589.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function useResultingCollateralizationRatioByCollateral({
  collateralValue,
  collateralRatio,
  minCollateralRatio,
  totalLoanAmount,
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Loans/hooks/CollateralizationRatio.ts and 1 other location - About 2 days to fix
    mobile-app/app/screens/AppNavigator/screens/Loans/hooks/CollateralizationRatioV2.ts on lines 98..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 589.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function AddLiquidityScreen has 556 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

    export function AddLiquidityScreen(props: Props): JSX.Element {
  const logger = useLogger();
  const navigation = useNavigation<NavigationProp<DexParamList>>();
  const dispatch = useAppDispatch();
  const DFIToken = useSelector((state: RootState) =>
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx - About 2 days to fix

      Function ConvertScreen has 548 lines of code (exceeds 100 allowed). Consider refactoring.
      Open

      export function ConvertScreen(props: Props): JSX.Element {
  const { getTokenPrice } = useTokenPrice();
  const { isLight } = useThemeContext();
  const { domain, isEvmFeatureEnabled } = useDomainContext();
  const isEvmDomain = domain === DomainType.EVM;
      Severity: Major
      Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ConvertScreen.tsx - About 2 days to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const AuctionFilterPillGroup = memo(
  (props: {
    onSearchBtnPress: () => void;
    onButtonGroupChange: (buttonGroupTabKey: ButtonGroupTabKey) => void;
    activeButtonGroup: ButtonGroupTabKey;
        Severity: Major
        Found in mobile-app/app/screens/AppNavigator/screens/Auctions/components/AuctionFilterPillGroup.tsx and 1 other location - About 2 days to fix
        mobile-app/app/screens/AppNavigator/screens/Dex/DexScreen.tsx on lines 411..483

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 511.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const DexFilterPillGroup = React.memo(
  (props: {
    onSearchBtnPress: () => void;
    onButtonGroupChange: (buttonGroupTabKey: ButtonGroupTabKey) => void;
    activeButtonGroup: ButtonGroupTabKey;
        Severity: Major
        Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexScreen.tsx and 1 other location - About 2 days to fix
        mobile-app/app/screens/AppNavigator/screens/Auctions/components/AuctionFilterPillGroup.tsx on lines 13..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 511.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function CompositeSwapScreen has a Cognitive Complexity of 107 (exceeds 5 allowed). Consider refactoring.
        Open

        export function CompositeSwapScreen({ route }: Props): JSX.Element {
  const logger = useLogger();
  const client = useWhaleApiClient();
  const whaleRpcClient = useWhaleRpcClient();
  const isFocused = useIsFocused();
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Dex/CompositeSwap/CompositeSwapScreen.tsx - About 2 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File AddOrRemoveCollateralScreen.tsx has 858 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import {
  ThemedScrollViewV2,
  ThemedTextV2,
  ThemedViewV2,
} from "@components/themed";
        Severity: Major
        Found in mobile-app/app/screens/AppNavigator/screens/Loans/screens/AddOrRemoveCollateralScreen.tsx - About 2 days to fix

          Function PortfolioNavigator has 473 lines of code (exceeds 100 allowed). Consider refactoring.
          Open

          export function PortfolioNavigator(): JSX.Element {
  const navigation = useNavigation<NavigationProp<PortfolioParamList>>();
  const { isLight } = useThemeContext();
  const { isEvmFeatureEnabled } = useDomainContext();
  const goToNetworkSelect = (): void => {
          Severity: Major
          Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/PortfolioNavigator.tsx - About 1 day to fix

            File AddressBookScreen.tsx has 810 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import { View } from "@components";
import {
  ThemedIcon,
  ThemedSectionTitleV2,
  ThemedTextV2,
            Severity: Major
            Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/AddressBookScreen.tsx - About 1 day to fix

              File PortfolioScreen.tsx has 799 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import {
  CommonActions,
  useIsFocused,
  useScrollToTop,
} from "@react-navigation/native";
              Severity: Major
              Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/PortfolioScreen.tsx - About 1 day to fix

                Function LoanCards has 430 lines of code (exceeds 100 allowed). Consider refactoring.
                Open

                export function LoanCards(props: LoanCardsProps): JSX.Element {
  const { isLight } = useThemeContext();
  const loanTokens = useSelector((state: RootState) =>
    loanTokensSelector(state.loans)
  );
                Severity: Major
                Found in mobile-app/app/screens/AppNavigator/screens/Loans/components/LoanCards.tsx - About 1 day to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function BlocksInfoRow({ blockCount }: { blockCount?: number }): JSX.Element {
  const { getBlocksUrl } = useDeFiScanContext();

  const onBlockUrlPressed = async (): Promise<void> => {
    if (blockCount !== undefined) {
                  Severity: Major
                  Found in mobile-app/app/screens/AppNavigator/screens/Settings/screens/NetworkSelectionScreen.tsx and 1 other location - About 1 day to fix
                  mobile-app/app/screens/WalletNavigator/screens/CreateWallet/OnboardingNetworkSelectScreen.tsx on lines 110..171

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 449.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function BlocksInfoRow({ blockCount }: { blockCount?: number }): JSX.Element {
  const { getBlocksUrl } = useDeFiScanContext();

  const onBlockUrlPressed = async (): Promise<void> => {
    if (blockCount !== undefined) {
                  Severity: Major
                  Found in mobile-app/app/screens/WalletNavigator/screens/CreateWallet/OnboardingNetworkSelectScreen.tsx and 1 other location - About 1 day to fix
                  mobile-app/app/screens/AppNavigator/screens/Settings/screens/NetworkSelectionScreen.tsx on lines 130..191

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 449.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  File BorrowLoanTokenScreen.tsx has 751 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import { Platform, View } from "react-native";
import {
  ThemedIcon,
  ThemedScrollViewV2,
  ThemedSectionTitleV2,
                  Severity: Major
                  Found in mobile-app/app/screens/AppNavigator/screens/Loans/screens/BorrowLoanTokenScreen.tsx - About 1 day to fix

                    File ConvertScreen.tsx has 747 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    import { NavigationProp, useNavigation } from "@react-navigation/native";
import { StackScreenProps } from "@react-navigation/stack";
import BigNumber from "bignumber.js";
import React, { useEffect, useState } from "react";
import { useThemeContext } from "@waveshq/walletkit-ui";
                    Severity: Major
                    Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ConvertScreen.tsx - About 1 day to fix

                      Function ConvertScreen has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
                      Open

                      export function ConvertScreen(props: Props): JSX.Element {
  const { getTokenPrice } = useTokenPrice();
  const { isLight } = useThemeContext();
  const { domain, isEvmFeatureEnabled } = useDomainContext();
  const isEvmDomain = domain === DomainType.EVM;
                      Severity: Minor
                      Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ConvertScreen.tsx - About 1 day to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File PortfolioNavigator.tsx has 662 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      import { NavigationProp, useNavigation } from "@react-navigation/native";
import { createStackNavigator } from "@react-navigation/stack";
import { AddressType, WalletToken } from "@waveshq/walletkit-ui/dist/store";
import BigNumber from "bignumber.js";
import { Image } from "expo-image";
                      Severity: Major
                      Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/PortfolioNavigator.tsx - About 1 day to fix

                        File ConfirmCompositeSwapScreen.tsx has 643 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        import { WalletAlert } from "@components/WalletAlert";
import { Dispatch, useEffect, useState } from "react";
import { useSelector } from "react-redux";
import { getColor, tailwind } from "@tailwind";
import { StackScreenProps } from "@react-navigation/stack";
                        Severity: Major
                        Found in mobile-app/app/screens/AppNavigator/screens/Dex/CompositeSwap/ConfirmCompositeSwapScreen.tsx - About 1 day to fix
                          Severity
                          Category
                          Status
                          Source
                          Language