DeFiCh/wallet

View on GitHub

Showing 286 of 335 total issues

Function paybackLoanToken has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  {
    vaultId,
    amountToPay,
    tokenBalance,
    loanToken,

    Function dfiConversionCrafter has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      amount: BigNumber,
      convertDirection: ConvertDirection,
      onBroadcast: () => any,
      onConfirmation: () => void,
      submitButtonLabel?: string,
    Severity: Minor
    Found in mobile-app/app/api/transaction/dfi_converter.ts - About 35 mins to fix

      Function editLoanScheme has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        { vaultId, loanScheme }: EditForm,
        dispatch: Dispatch<any>,
        onBroadcast: () => void,
        onConfirmation: () => void,
        logger: NativeLoggingProps

        Function dvmToDvmSendSigner has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          account: WhaleWalletAccount,
          token: WalletToken,
          amount: BigNumber,
          address: string,
          networkName: NetworkName,

          Function getActivePrice has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            symbol: string,
            activePrice?: ActivePrice,
            collateralFactor: string = "1",
            priceType: ActivePriceType = "ACTIVE",
            tokenType: TokenType = "LOAN"

            Function TokenDropdownButton has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function TokenDropdownButton(props: {
              tokenId?: string;
              symbol?: string;
              displayedTextSymbol?: string;
              testID: string;
            Severity: Minor
            Found in mobile-app/app/components/TokenDropdownButton.tsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function RowNetworkItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function RowNetworkItem(props: RowNetworkItemProps): JSX.Element {
              const navigation = useNavigation<NavigationProp<SettingsParamList>>();
              const { network, updateNetwork } = useNetworkContext();
            
              const onPress = async (): Promise<void> => {
            Severity: Minor
            Found in mobile-app/app/components/RowNetworkItem.tsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function VerifyMnemonicWallet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function VerifyMnemonicWallet({
              route,
              navigation,
            }: Props): JSX.Element {
              const recoveryWords = route.params.words;

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function ResetButton has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function ResetButton(): JSX.Element {
              const { isEvmFeatureEnabled } = useDomainContext();
              const navigation = useNavigation<NavigationProp<SettingsParamList>>();
              const logger = useLogger();
              const dispatch = useAppDispatch();

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function ConfirmPinScreen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function ConfirmPinScreen({ route }: Props): JSX.Element {
              const logger = useLogger();
              const navigation = useNavigation();
              const { network } = useNetworkContext();
              const { setWallet } = useWalletPersistenceContext();

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function InfoSection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function InfoSection({
              type,
              pair,
              tokenATotal,
              tokenBTotal,

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function AnnouncementBanner has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function AnnouncementBanner({
              hideAnnouncement,
              announcement,
              testID,
            }: AnnouncementBannerProps): JSX.Element {

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function PromptContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            const PromptContent = React.memo((props: PasscodePromptProps): JSX.Element => {
              return (
                <>
                  <ThemedTouchableOpacityV2
                    light={tailwind("bg-mono-light-v2-100")}
            Severity: Minor
            Found in mobile-app/app/screens/TransactionAuthorization/PasscodePrompt.tsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getBaseTranslationsMap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function getBaseTranslationsMap(): Map<string, string[]> {
              const BASE_TRANSLATION_LOCALE = "de";
              const baseTranslations = translations[BASE_TRANSLATION_LOCALE];
              const map = new Map<string, string[]>();
            
            
            Severity: Minor
            Found in shared/translations/reporter/index.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function modifyCollateral has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            async function modifyCollateral(
              { vaultId, tokenAmount, token, isAdd }: ModifyCollateralForm,
              dispatch: Dispatch<any>,
              logger: NativeLoggingProps,
              onBroadcast: () => void,

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function EditLoanSchemeScreen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function EditLoanSchemeScreen({
              route,
              navigation,
            }: Props): JSX.Element {
              const { vaultId } = route.params;

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function OCGConfirmScreen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function OCGConfirmScreen({ route }: Props): JSX.Element {
              const {
                type,
                fee,
                proposalFee,

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                return {
                  code: ErrorCodes.InsufficientDFIInVault,
                  message: "Insufficient DFI collateral. (≥50%)",
                };
            Severity: Major
            Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return {
                    code: ErrorCodes.LackOfLiquidity,
                    message: "Insufficient liquidity.",
                  };
              Severity: Major
              Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return {
                      code: ErrorCodes.DustValue,
                      message: "Input amount is too low. Increase the amount to continue.",
                    };
                Severity: Major
                Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language