DeFiCh/wallet

View on GitHub

Showing 286 of 335 total issues

Avoid too many return statements within this function.
Open

  return {
    code: ErrorCodes.UnknownError,
    message: getErrorMessage(err),
  };
Severity: Major
Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return null;

      Avoid too many return statements within this function.
      Open

          return {
            code: ErrorCodes.NoLiveFixedPrices,
            message: "No live fixed prices for loan token.",
          };
      Severity: Major
      Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return {
              code: ErrorCodes.VaultNotEnoughCollateralization,
              message:
                "Vault does not meet min. collateral ratio. Add collateral to proceed.",
            };
        Severity: Major
        Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return (
              <ThemedIcon
                light={tailwind("text-mono-light-v2-700 opacity-30")}
                dark={tailwind("text-mono-light-v2-700 opacity-30")}
                iconType="MaterialIcons"

            Avoid too many return statements within this function.
            Open

                return {
                  code: ErrorCodes.CfpProposalExceedAmount,
                  message: "Requested amount is higher than available amount.",
                };
            Severity: Major
            Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return {
                    code: ErrorCodes.PaybackLoanInvalidPrice,
                    message: "Unable to payback loan due to invalid price.",
                  };
              Severity: Major
              Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return true;

                  Avoid too many return statements within this function.
                  Open

                      return domain === DomainType.DVM ? dvmTokens : evmTokens;

                    Function WalletAlert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function WalletAlert(option: CustomAlertOption): void {
                      if (Platform.OS !== "web") {
                        Alert.alert(option.title, option.message, option.buttons, option.options);
                      } else if (option.buttons === undefined || option.buttons.length === 0) {
                        window.alert([option.title, option.message].filter(Boolean).join("\n"));
                    Severity: Minor
                    Found in mobile-app/app/components/WalletAlert.tsx - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function useTotalCollateralValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function useTotalCollateralValue({
                      vault,
                      token,
                      isAdd,
                      collateralInputValue,

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function FeatureFlagProvider has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function FeatureFlagProvider(
                      props: React.PropsWithChildren<any>,
                    ): JSX.Element | null {
                      const { network } = useNetworkContext();
                      const { url, isCustomUrl } = useServiceProviderContext();
                    Severity: Minor
                    Found in mobile-app/app/contexts/FeatureFlagContext.tsx - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function LoanPercentage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function LoanPercentage({
                      amountToPayInLoanToken,
                      amountToPayInPaymentToken,
                      loanTokenOutstandingBalance,
                      outstandingBalanceInPaymentToken,

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function Vaults has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function Vaults(props: VaultsProps): JSX.Element {
                      const dispatch = useAppDispatch();
                      const client = useWhaleApiClient();
                      const isFocused = useIsFocused();
                      const { address } = useWalletContext();
                    Severity: Minor
                    Found in mobile-app/app/screens/AppNavigator/screens/Loans/components/Vaults.tsx - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function CustomUrlInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function CustomUrlInput({
                      type,
                      url,
                      defaultUrl,
                      label,

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function useBottomSheet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export const useBottomSheet = (): {
                      isModalDisplayed: boolean;
                      setIsModalDisplayed: (val: boolean) => void;
                      containerRef: React.Ref<any>;
                      bottomSheetRef: React.Ref<BottomSheetModal>;
                    Severity: Minor
                    Found in mobile-app/app/hooks/useBottomSheet.tsx - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function RestoreMnemonicWallet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function RestoreMnemonicWallet(): JSX.Element {
                      const navigation = useNavigation<NavigationProp<WalletParamList>>();
                      const {
                        control,
                        formState: { isValid, isDirty },

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function useCollateralTokenList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function useCollateralTokenList() {
                      const tokens = useSelector((state: RootState) =>
                        tokensSelector(state.wallet)
                      );
                    
                    

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function WalletContextProvider has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function WalletContextProvider(
                      props: WalletContextProviderProps,
                    ): JSX.Element | null {
                      const { api } = props;
                      const logger = useLogger();
                    Severity: Minor
                    Found in shared/contexts/WalletContext.tsx - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function useTokenBestPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function useTokenBestPath(): TokenBestPath {
                      const client = useWhaleApiClient();
                      const blockCount = useSelector((state: RootState) => state.block.count);
                      const pairs = useSelector((state: RootState) => state.wallet.poolpairs);
                      const { network } = useNetworkContext();

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language