Sign upLogin

Defelo/PyCrypCli

View on GitHub
Star
PyCrypCli/commands/network.py

Summary

Maintainability
C
1 day
Test Coverage

Function handle_membership_request has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

def handle_membership_request(context: DeviceContext, args: list[str], accept: bool) -> None:
    if len(args) not in (1, 2):
        raise CommandError(f"usage: network {['deny', 'accept'][accept]} <network> [<device>]")

    network: Network = get_network(context, args[0])
Severity: Minor
Found in PyCrypCli/commands/network.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File network.py has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from typing import Any

from .command import command, CommandError
from .device import get_device
from .help import print_help
Severity: Minor
Found in PyCrypCli/commands/network.py - About 3 hrs to fix

    Function network_accept_deny_completer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def network_accept_deny_completer(context: DeviceContext, args: list[str]) -> list[str]:
    if len(args) == 1:
        return [*{*device_network_names(context), *invitation_network_names(context)}]
    if len(args) == 2:
        try:
    Severity: Minor
    Found in PyCrypCli/commands/network.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function network_kick_completer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def network_kick_completer(context: DeviceContext, args: list[str]) -> list[str]:
    if len(args) == 1:
        return [*{*device_network_names(context)}]
    if len(args) == 2:
        try:
    Severity: Minor
    Found in PyCrypCli/commands/network.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status