Sign upLogin

DeflatedPickle/FAOSDance

View on GitHub
Star

Showing 178 of 178 total issues

Method paintBorder has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override fun paintBorder(
        c: Component,
        g: Graphics,
        x: Int, y: Int,
        width: Int, height: Int
Severity: Major
Found in src/main/kotlin/com/deflatedpickle/faosdance/autoupdate/SpeechBubbleBorder.kt - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            g2D.scale(GlobalValues.optionsMap.getMap("sprite")!!.getMap("size")!!.getOption<Double>("width")!!, GlobalValues.optionsMap.getMap("sprite")!!.getMap("size")!!.getOption<Double>("height")!!)
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/SpritePanel.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/main.kt on lines 69..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 185.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            frame.setLocation(GlobalValues.optionsMap.getMap("window")!!.getMap("location")!!.getOption<Int>("x")!!, GlobalValues.optionsMap.getMap("window")!!.getMap("location")!!.getOption<Int>("y")!!)
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/main.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/gui/SpritePanel.kt on lines 108..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 185.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def post_draw_sprite(graphics)
    if @future_frame_amount > 0
      for i in 0..@future_frame_amount
        frame = GlobalValues.getOption "sprite.animation.frame"
        action = GlobalValues.getOption "sprite.animation.action"
    Severity: Major
    Found in src/main/resources/scripts/blend_extension.rb and 1 other location - About 2 hrs to fix
    src/main/resources/scripts/blend_extension.rb on lines 12..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def pre_draw_sprite(graphics)
    if @past_frame_amount > 0
      for i in 0..@past_frame_amount
        frame = GlobalValues.getOption "sprite.animation.frame"
        action = GlobalValues.getOption "sprite.animation.action"
    Severity: Major
    Found in src/main/resources/scripts/blend_extension.rb and 1 other location - About 2 hrs to fix
    src/main/resources/scripts/blend_extension.rb on lines 36..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun addLabelSliderSpinnerDouble(
        parent: Container,
        gridBagLayout: GridBagLayout,
        name: String,
        defaultValue: Double,
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/util/GlobalValues.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/util/GlobalValues.kt on lines 313..329

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 180.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun addLabelSliderSpinnerInteger(
        parent: Container,
        gridBagLayout: GridBagLayout,
        name: String,
        defaultValue: Int,
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/util/GlobalValues.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/util/GlobalValues.kt on lines 295..311

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 180.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method post_draw_sprite has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def post_draw_sprite(graphics)
    if @future_frame_amount > 0
      for i in 0..@future_frame_amount
        frame = GlobalValues.getOption "sprite.animation.frame"
        action = GlobalValues.getOption "sprite.animation.action"
    Severity: Minor
    Found in src/main/resources/scripts/blend_extension.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pre_draw_sprite has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def pre_draw_sprite(graphics)
    if @past_frame_amount > 0
      for i in 0..@past_frame_amount
        frame = GlobalValues.getOption "sprite.animation.frame"
        action = GlobalValues.getOption "sprite.animation.action"
    Severity: Minor
    Found in src/main/resources/scripts/blend_extension.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        val reloadExtensionButton = JButton(Lang.bundle.getString("settings.extensions.reload_all")).apply {
        addActionListener {
            GlobalValues.loadScripts()
            JOptionPane.showMessageDialog(
                GlobalValues.frame,
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/ExtensionSettings.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/SettingsDialog.kt on lines 25..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        val saveConfigurationButton = JButton(Lang.bundle.getString("settings.save_configuration")).apply {
        addActionListener {
            ConfigFile.writeConfig()
            JOptionPane.showMessageDialog(
                GlobalValues.frame,
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/SettingsDialog.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/ExtensionSettings.kt on lines 18..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                addActionListener {
                GlobalValues.optionsMap.getMap("window")!!.setOption("solid", this.isSelected)
                GlobalValues.updateScripts("window.solid", GlobalValues.optionsMap.getMap("window")!!.getOption<Boolean>("solid")!!)
            }
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/general/WindowCategory.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/general/SpriteCategory.kt on lines 202..205

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                addActionListener {
                GlobalValues.optionsMap.getMap("sprite")!!.setOption("toggle_held", this.isSelected)
                GlobalValues.updateScripts("sprite.toggle_held", GlobalValues.optionsMap.getMap("sprite")!!.getOption<Boolean>("toggle_held")!!)
            }
    Severity: Major
    Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/general/SpriteCategory.kt and 1 other location - About 2 hrs to fix
    src/main/kotlin/com/deflatedpickle/faosdance/gui/settings/general/WindowCategory.kt on lines 24..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method createEnviromentFiles has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

        fun createEnviromentFiles() {
        homePath?.mkdir()

        // It's a loop in case I decide to add more user folders, or move the lang folder out of the program
        for (i in listOf(
    Severity: Minor
    Found in src/main/kotlin/com/deflatedpickle/faosdance/util/GlobalValues.kt - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method main has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
    Open

    @Suppress("KDocMissingDocumentation")
fun main() {
    UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName())

    if (UpdateUtil.isOutdated) {
    Severity: Minor
    Found in src/main/kotlin/com/deflatedpickle/faosdance/main.kt - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method main has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    @Suppress("KDocMissingDocumentation")
fun main() {
    UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName())

    if (UpdateUtil.isOutdated) {
    Severity: Minor
    Found in src/main/kotlin/com/deflatedpickle/faosdance/main.kt - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  (this.height - GlobalValues.sheet!!.spriteHeight * GlobalValues.optionsMap.getMap("sprite")!!.getMap("size")!!.getOption<Double>("height")!!) / 2
      Severity: Major
      Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/SpritePanel.kt and 1 other location - About 1 hr to fix
      src/main/kotlin/com/deflatedpickle/faosdance/gui/SpritePanel.kt on lines 96..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 134.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  (this.width - GlobalValues.sheet!!.spriteWidth * GlobalValues.optionsMap.getMap("sprite")!!.getMap("size")!!.getOption<Double>("width")!!) / 2,
      Severity: Major
      Found in src/main/kotlin/com/deflatedpickle/faosdance/gui/SpritePanel.kt and 1 other location - About 1 hr to fix
      src/main/kotlin/com/deflatedpickle/faosdance/gui/SpritePanel.kt on lines 97..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 134.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method paintBorder has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void paintBorder(Component c, Graphics g, int x, int y, int width,
                            int height) {
        Rectangle borderR = new Rectangle(x + EDGE_SPACING, y + EDGE_SPACING,
                width - (EDGE_SPACING * 2), height - (EDGE_SPACING * 2));
        Insets borderInsets;
      Severity: Minor
      Found in src/main/java/com/deflatedpickle/faosdance/component_border/ComponentBorder.java - About 1 hr to fix

        Method getComponentRect has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public Rectangle getComponentRect(Rectangle rect, Insets borderInsets) {
        Dimension compD = component.getPreferredSize();
        Rectangle compR = new Rectangle(0, 0, compD.width, compD.height);
        switch (titlePosition) {
            case ABOVE_TOP:
        Severity: Minor
        Found in src/main/java/com/deflatedpickle/faosdance/component_border/ComponentBorder.java - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language