Sign upLogin

DeflatedPickle/Quiver

View on GitHub
Star
core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt

Summary

Maintainability
F
2 wks
Test Coverage

Method createEmptyPack has a Cognitive Complexity of 671 (exceeds 20 allowed). Consider refactoring.
Open

    // This structure is mostly the same through different pack versions
    // I'm not sure of a good, maintainable way to describe these mild differences, though I did write a DSL for it
    // https://minecraft.gamepedia.com/Resource_Pack#Folder_structure
    // (02/05/2021) This testing of each file is quite verbose. Perhaps some kind of "checker" could be added to the FileBuilder?
    fun createEmptyPack(
Severity: Minor
Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                            if (ps.assets.minecraft.textures.gui.container != null) dir("container") {
                                if (ps.assets.minecraft.textures.gui.container.creativeInventory) dir("creative_inventory") {}
                            }
Severity: Major
Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if (image.width == image.height) {
                            return image.width
                        }
    Severity: Major
    Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (ps.assets.minecraft.textures.gui.presets) dir("presets") {}
      Severity: Major
      Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (ps.assets.minecraft.textures.gui.advancements != null) dir("advancements") {
                                if (ps.assets.minecraft.textures.gui.advancements.backgrounds) dir("backgrounds") {}
                            }
        Severity: Major
        Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (ps.assets.minecraft.textures.gui.title != null) dir("title") {
                                if (ps.assets.minecraft.textures.gui.title.background) dir("background") {}
                            }
          Severity: Major
          Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (ps.assets.minecraft.textures.models.armor) dir("armor") {}
            Severity: Major
            Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (ps.assets.minecraft.models != null) dir("models") {
                        if (ps.assets.minecraft.models.block) dir("block") {}
                        if (ps.assets.minecraft.models.item) dir("item") {}
                    }
              Severity: Major
              Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt and 1 other location - About 2 hrs to fix
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 129..132

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 157.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (ps.assets.minecraft.shaders != null) dir("shaders") {
                        if (ps.assets.minecraft.shaders.post) dir("post") {}
                        if (ps.assets.minecraft.shaders.program) dir("program") {}
                    }
              Severity: Major
              Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt and 1 other location - About 2 hrs to fix
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 123..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 157.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                          if (ps.assets.minecraft.textures.gui.title != null) dir("title") {
                                if (ps.assets.minecraft.textures.gui.title.background) dir("background") {}
                            }
              Severity: Major
              Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt and 2 other locations - About 1 hr to fix
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 142..144
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 145..147

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 126.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                          if (ps.assets.minecraft.textures.gui.advancements != null) dir("advancements") {
                                if (ps.assets.minecraft.textures.gui.advancements.backgrounds) dir("backgrounds") {}
                            }
              Severity: Major
              Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt and 2 other locations - About 1 hr to fix
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 145..147
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 149..151

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 126.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                          if (ps.assets.minecraft.textures.gui.container != null) dir("container") {
                                if (ps.assets.minecraft.textures.gui.container.creativeInventory) dir("creative_inventory") {}
                            }
              Severity: Major
              Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt and 2 other locations - About 1 hr to fix
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 142..144
              core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt on lines 149..151

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 126.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status