Sign upLogin

DeflatedPickle/Quiver

View on GitHub
Star

Showing 96 of 96 total issues

Avoid deeply nested control flow statements.
Open

                            if (ps.assets.minecraft.textures.gui.title != null) dir("title") {
                                if (ps.assets.minecraft.textures.gui.title.background) dir("background") {}
                            }
Severity: Major
Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if (ps.assets.minecraft.textures.models.armor) dir("armor") {}
    Severity: Major
    Found in core/src/main/kotlin/com/deflatedpickle/quiver/backend/util/PackUtil.kt - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              EventProgramFinishSetup.addListener {
            this.fileModel.setDataVector(
                arrayOf(),
                arrayOf(
                    "Name",
      Severity: Minor
      Found in filetable/src/main/kotlin/com/deflatedpickle/quiver/filetable/FileTable.kt and 1 other location - About 40 mins to fix
      tableviewer/src/main/kotlin/com/deflatedpickle/tableviewer/Component.kt on lines 15..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              EventProgramFinishSetup.addListener {
            this.fileModel.setDataVector(
                arrayOf(),
                arrayOf(
                    "Key",
      Severity: Minor
      Found in tableviewer/src/main/kotlin/com/deflatedpickle/tableviewer/Component.kt and 1 other location - About 40 mins to fix
      filetable/src/main/kotlin/com/deflatedpickle/quiver/filetable/FileTable.kt on lines 47..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method getListCellRendererComponent has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                      list: JList<*>?,
                value: Any?,
                index: Int,
                isSelected: Boolean,
                cellHasFocus: Boolean
      Severity: Minor
      Found in core/src/main/kotlin/com/deflatedpickle/quiver/frontend/dialog/UsagesDialog.kt - About 35 mins to fix

        Method getListCellRendererComponent has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                            list: JList<*>,
                    value: Any,
                    index: Int,
                    isSelected: Boolean,
                    cellHasFocus: Boolean
        Severity: Minor
        Found in packexport/src/main/kotlin/com/deflatedpickle/quiver/packexport/ExportPackDialog.kt - About 35 mins to fix

          Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string: String,
        caseInsensitive: Boolean = true,
        comments: Boolean = false,
        start: Int = -1,
        backwards: Boolean = false
          Severity: Minor
          Found in core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt - About 35 mins to fix

            Method addDropTarget has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

                private fun addDropTarget() {
        this.dropTarget = object : DropTarget() {
            @Suppress("UNCHECKED_CAST")
            override fun dragEnter(dtde: DropTargetDragEvent) {
                val file = Quiver.selectedFile
            Severity: Minor
            Found in filepanel/src/main/kotlin/com/deflatedpickle/quiver/filepanel/widget/ReplaceButton.kt - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                override fun getSlug(): Slug = Slug(
        "DeflatedPickle",
        "PackSquash",
        Version(1, 0, 0)
    )
            Severity: Minor
            Found in packsquashstep/src/main/kotlin/com/deflatedpickle/quiver/packsquashstep/PackSquashStep.kt and 1 other location - About 35 mins to fix
            zipstep/src/main/kotlin/com/deflatedpickle/quiver/zipstep/ZipStep.kt on lines 21..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                override fun getSlug(): Slug = Slug(
        "DeflatedPickle",
        "Zip",
        Version(1, 0, 0)
    )
            Severity: Minor
            Found in zipstep/src/main/kotlin/com/deflatedpickle/quiver/zipstep/ZipStep.kt and 1 other location - About 35 mins to fix
            packsquashstep/src/main/kotlin/com/deflatedpickle/quiver/packsquashstep/PackSquashStep.kt on lines 24..28

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                private val loopButton = JToggleButton(MonoIcon.RELOAD).apply {
        toolTipText = "Loop"
        isSelected = true
    }
            Severity: Minor
            Found in core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt and 2 other locations - About 35 mins to fix
            core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt on lines 85..88
            core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt on lines 90..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                private val ignoreWhitespaceCheckbox = JToggleButton(MonoIcon.IGNORE_WHITESPACE).apply {
        toolTipText = "Ignore Whitespace"
        isSelected = true
    }
            Severity: Minor
            Found in core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt and 2 other locations - About 35 mins to fix
            core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt on lines 76..79
            core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt on lines 90..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                // Non-regex checks
    private val stripSpecialChecks = JToggleButton(MonoIcon.STRIP_SPECIAL_CHARACTERS).apply {
        toolTipText = "Strip Special Characters"
        isSelected = true
    }
            Severity: Minor
            Found in core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt and 2 other locations - About 35 mins to fix
            core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt on lines 76..79
            core/src/main/kotlin/com/deflatedpickle/quiver/frontend/widget/SearchToolbar.kt on lines 85..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                logger.info("Loaded plugins; ${PluginUtil.loadedPlugins.map { PluginUtil.pluginToSlug(it) }}")
            Severity: Minor
            Found in launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt and 2 other locations - About 35 mins to fix
            launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt on lines 137..137
            launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt on lines 158..158

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    logger.warn("Failed to load; ${PluginUtil.unloadedPlugins.map { PluginUtil.pluginToSlug(it) }}")
            Severity: Minor
            Found in launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt and 2 other locations - About 35 mins to fix
            launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt on lines 137..137
            launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt on lines 154..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                logger.debug("Sorted out the load order: ${PluginUtil.discoveredPlugins.map { PluginUtil.pluginToSlug(it) }}")
            Severity: Minor
            Found in launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt and 2 other locations - About 35 mins to fix
            launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt on lines 154..154
            launcher/src/main/kotlin/com/deflatedpickle/quiver/launcher/main.kt on lines 158..158

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language