Sign upLogin

DemacMedia/Magento-Multi-Location-Inventory

View on GitHub
Star
app/code/community/Demac/MultiLocationInventory/Model/Importexport/Observer.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function importMultiLocationInventory has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function importMultiLocationInventory(Varien_Event_Observer $observer)
    {
        /** @var Mage_ImportExport_Model_Import_Entity_Product $adapter */
        $adapter = $observer->getData('adapter');
        if(!$adapter) {
Severity: Minor
Found in app/code/community/Demac/MultiLocationInventory/Model/Importexport/Observer.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method importMultiLocationInventory has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function importMultiLocationInventory(Varien_Event_Observer $observer)
    {
        /** @var Mage_ImportExport_Model_Import_Entity_Product $adapter */
        $adapter = $observer->getData('adapter');
        if(!$adapter) {
Severity: Minor
Found in app/code/community/Demac/MultiLocationInventory/Model/Importexport/Observer.php - About 1 hr to fix

There are no issues that match your filters.

Category
Status