Sign upLogin

DemocracyOS/democracyos

View on GitHub
Star

Showing 430 of 430 total issues

Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { topic, user } = this.props

    if (user.state.pending) return null
Severity: Minor
Found in lib/site/topic-layout/topic-article/comments/form/component.js - About 2 hrs to fix

    Function Setup has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Setup (app) {
  /**
   * Set `production` settings
   */
    Severity: Minor
    Found in lib/setup/index.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        canVote (forum, user, topic) {
    if (forum.hasVisibility('public', 'collaborative')) return true
    if (!config.multiForum && user && user.staff) return true
    return forum.isOwner(user) || forum.hasRole(user)
  },
      Severity: Major
      Found in lib/privileges/topic.js and 1 other location - About 2 hrs to fix
      lib/privileges/topic.js on lines 46..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        canComment (forum, user, topic) {
    if (forum.hasVisibility('public', 'collaborative')) return true
    if (!config.multiForum && user && user.staff) return true
    return forum.isOwner(user) || forum.hasRole(user)
  }
      Severity: Major
      Found in lib/privileges/topic.js and 1 other location - About 2 hrs to fix
      lib/privileges/topic.js on lines 40..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function render has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render () {
    const { votesTotals, results, voted } = this.props
    const noVoted = votesTotals === 0
    if (noVoted) {
      return (
      Severity: Minor
      Found in lib/site/topic-layout/topic-article/hierarchy/component.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              return new Promise(function (resolve, reject) {
        Comment.update(query, data, { multi: true }, function (err) {
          if (err) {
            console.log('Error saving comment: ' + err.toString())
          }
        Severity: Major
        Found in migrations/1487112733708-update-topic-clauses.js and 1 other location - About 1 hr to fix
        migrations/1487112733708-update-topic-clauses.js on lines 154..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              commentsUpdates.push(new Promise(function (resolve, reject) {
        Comment.update(query, data, { multi: true }, function (err) {
          if (err) {
            console.log('Error saving comment: ' + err.toString())
          }
        Severity: Major
        Found in migrations/1487112733708-update-topic-clauses.js and 1 other location - About 1 hr to fix
        migrations/1487112733708-update-topic-clauses.js on lines 92..100

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function TopicConnectorFactory has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export default function TopicConnectorFactory (WrappedComponent) {
  return class TopicConnector extends Component {
    static displayName = `TopicConnector(${getDisplayName(WrappedComponent)})`

    static WrappedComponent = WrappedComponent
        Severity: Minor
        Found in lib/site/connectors/topic.js - About 1 hr to fix

          Function render has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render () {
    const { user, topic } = this.props

    if (user.state.pending) return null
          Severity: Minor
          Found in lib/site/topic-layout/topic-article/cause/component.js - About 1 hr to fix

            Function render has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              render () {
    let source = null
    if (this.props.source) {
      source = (
        <div className='source'>
            Severity: Minor
            Found in lib/site/topic-layout/topic-article/footer/component.js - About 1 hr to fix

              Function ResultBox has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function ResultBox (props) {
  const votesTotal = props.votesTotal
  const votes = props.votes
  const resultChartDidMount = props.resultChartDidMount
  const options = props.options
              Severity: Minor
              Found in lib/site/topic-layout/topic-article/vote/component.js - About 1 hr to fix

                Function render has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  render () {
    if (config.visibility === 'hidden' && this.props.user.state.rejected) {
      browserHistory.push('/signin')
      return null
    }
                Severity: Minor
                Found in lib/site/home-forum/component.js - About 1 hr to fix

                  Function CommentFooter has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export default function CommentFooter (props) {
  return (
    <footer className='actions'>
      <div className='votes'>
        <span className='score'>
                  Severity: Minor
                  Found in lib/site/topic-layout/topic-article/comments/list/comment/footer/component.js - About 1 hr to fix

                    Function migrateV1 has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function migrateV1 (topic) {
  const data = {}

  data.clauses = topic.clauses.map((clause) => ({
    id: clause._id,
                    Severity: Minor
                    Found in migrations/1487112733708-update-topic-clauses.js - About 1 hr to fix

                      Function up has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      exports.up = function up (done) {
  // firstName 100
  // lastName 100
  // username 100
  // email 200
                      Severity: Minor
                      Found in migrations/1487112733700-update-users-maxlengths.js - About 1 hr to fix

                        Function create has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        exports.create = function create (opts, attrs) {
  const user = opts.user
  const forum = opts.forum

  attrs.forum = forum._id
                        Severity: Minor
                        Found in lib/api-v2/db-api/topics/index.js - About 1 hr to fix

                          Function migrateV2 has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function migrateV2 (topic) {
  const html = topic._doc && topic._doc.summary
  const document = getDOM(html)
  if (!document) throw Error('Bad topic _doc')
  const divs = document.getElementsByTagName('div')
                          Severity: Minor
                          Found in migrations/1487112733708-update-topic-clauses.js - About 1 hr to fix

                            Function postCsv has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function postCsv (req, res) {
  const body = req.body.csv
  csv2json(body, function (err, json) {
    if (err) {
      log('get csv: array to csv error', err)
                            Severity: Minor
                            Found in lib/api-v2/topics/csv.js - About 1 hr to fix

                              Function commentsSyncFactory has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function commentsSyncFactory () {
  let items = []

  const params = {
    topicId: null,
                              Severity: Minor
                              Found in lib/site/topic-layout/topic-article/comments/connector.js - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                              page(urlBuilder.for('admin.comments'), (ctx) => {
  ctx.sidebar.set('comments')
  render(<AdminComments forum={ctx.forum} />, document.querySelector('.admin-content'))
})
                              Severity: Major
                              Found in lib/admin/admin/admin.js and 2 other locations - About 1 hr to fix
                              lib/admin/admin/admin.js on lines 147..150
                              lib/admin/admin/admin.js on lines 152..155

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 70.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language