Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Billing/Accounting/ApiBankReference.php

Summary

Maintainability
F
5 days
Test Coverage

File ApiBankReference.php has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Api\Billing\Accounting;

use SPHERE\Application\Api\ApiTrait;
use SPHERE\Application\Api\Dispatcher;
Severity: Minor
Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 5 hrs to fix

    Function deleteReference has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        public function deleteReference($Identifier = '', $PersonId = '', $ReferenceId = '')
    {

        if(($tblReference = Debtor::useService()->getBankReferenceById($ReferenceId))){
            $RowContent = array();
    Severity: Minor
    Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deleteReference has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function deleteReference($Identifier = '', $PersonId = '', $ReferenceId = '')
    {

        if(($tblReference = Debtor::useService()->getBankReferenceById($ReferenceId))){
            $RowContent = array();
    Severity: Major
    Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 2 hrs to fix

      Method showDeleteReference has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function showDeleteReference($Identifier = '', $PersonId = '', $ReferenceId = '')
    {

        $tblReference = Debtor::useService()->getBankReferenceById($ReferenceId);
      Severity: Minor
      Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 1 hr to fix

        Method formReference has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function formReference($Identifier = '', $PersonId = '', $ReferenceId = '')

    {

        // choose between Add and Edit
        Severity: Minor
        Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 1 hr to fix

          Function checkInputReference has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function checkInputReference($Identifier = '', $PersonId = '', $ReferenceId = '',
        $Reference = array()
    ){

        $Error = false;
          Severity: Minor
          Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                      if(($tblItem = $tblBasketVerification->getServiceTblItem())){
                                $ItemString = $tblItem->getName();
                            }
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 45 mins to fix

            Function formReference has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function formReference($Identifier = '', $PersonId = '', $ReferenceId = '')

    {

        // choose between Add and Edit
            Severity: Minor
            Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function saveAddReference has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function saveAddReference($Identifier = '', $PersonId = '', $Reference = array())
    {

        // Handle error's
        if($form = $this->checkInputReference($Identifier, $PersonId, '', $Reference)){
            Severity: Minor
            Found in Application/Api/Billing/Accounting/ApiBankReference.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public static function pipelineOpenEditReferenceModal($Identifier = '', $PersonId = '', $ReferenceId = '',
        $Reference = array()
    ){

        $Receiver = self::receiverModal(null, $Identifier);
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 2 other locations - About 3 hrs to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 147..166
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 154..173

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 147.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public static function pipelineSaveEditReference($Identifier = '', $PersonId = '', $ReferenceId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline(true);
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 2 other locations - About 2 hrs to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 175..193
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 182..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 135.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public static function pipelineOpenAddReferenceModal($Identifier = '', $PersonId = '', $Reference = array())
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 2 other locations - About 2 hrs to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 96..113
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 103..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                public static function pipelineOpenDeleteReferenceModal($Identifier = '', $PersonId = '', $ReferenceId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 6 other locations - About 2 hrs to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 202..219
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 228..245
            Application/Api/Billing/Accounting/ApiBankReference.php on lines 231..248
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 208..225
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 234..251
            Application/Api/Billing/Accounting/ApiDebtorSelection.php on lines 146..163

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                public static function pipelineDeleteReference($Identifier = '', $PersonId = '', $ReferenceId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 6 other locations - About 2 hrs to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 202..219
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 228..245
            Application/Api/Billing/Accounting/ApiBankReference.php on lines 205..222
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 208..225
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 234..251
            Application/Api/Billing/Accounting/ApiDebtorSelection.php on lines 146..163

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public static function pipelineCloseModal($Identifier = '', $PersonId = '')
    {
        $Pipeline = new Pipeline();
        // reload the whole Table
        $Emitter = new ServerEmitter(self::receiverPanelContent(''), self::getEndpoint());
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 2 other locations - About 2 hrs to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 253..267
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 259..273

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        return new Layout(
                new LayoutGroup(
                    new LayoutRow(array(
                        new LayoutColumn(
                            new Panel('Soll die Mandatsreferenznummer wirklich entfernt werden?'
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 2 other locations - About 1 hr to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 500..515
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 561..576

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 119.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 14 locations. Consider refactoring.
            Open

                public static function pipelineSaveAddReference($Identifier = '', $PersonId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 13 other locations - About 1 hr to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
            Application/Api/Billing/Accounting/ApiCreditor.php on lines 189..205
            Application/Api/Billing/Accounting/ApiCreditor.php on lines 213..229
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
            Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
            Application/Api/Billing/Inventory/ApiItem.php on lines 214..230
            Application/Api/Billing/Inventory/ApiItem.php on lines 238..254
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
            Application/Api/Billing/Inventory/ItemVariant.php on lines 148..164
            Application/Api/Billing/Inventory/ItemVariant.php on lines 172..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if($form = $this->checkInputReference($Identifier, $PersonId, $ReferenceId, $Reference)){
            // display Errors on form
            $Global = $this->getGlobal();
            $Global->POST['Reference']['Number'] = $Reference['Number'];
            $Global->POST['Reference']['Description'] = $Reference['Description'];
            Severity: Major
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 1 other location - About 1 hr to fix
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 452..460

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        $RowContent[] = new Layout(
                                new LayoutGroup(
                                    new LayoutRow(array(
                                        new LayoutColumn('Beitragsart:', 2),
                                        new LayoutColumn(new Bold($ItemString), 4),
            Severity: Minor
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 1 other location - About 50 mins to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 544..553

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(($tblReference = Debtor::useService()->getBankReferenceByReference($Reference['Number']))){
                $tblPerson = Person::useService()->getPersonById($PersonId);
                if($tblPerson && ($tblPersonCompare = $tblReference->getServiceTblPerson())
                    && $tblPerson->getId() !== $tblPersonCompare->getId()){
                    $form->setError('Reference[Number]',
            Severity: Minor
            Found in Application/Api/Billing/Accounting/ApiBankReference.php and 1 other location - About 35 mins to fix
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 411..419

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status