Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Billing/Accounting/ApiCreditor.php

Summary

Maintainability
F
4 days
Test Coverage

File ApiCreditor.php has 397 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Api\Billing\Accounting;

use SPHERE\Application\Api\ApiTrait;
use SPHERE\Application\Api\Dispatcher;
Severity: Minor
Found in Application/Api/Billing/Accounting/ApiCreditor.php - About 5 hrs to fix

    Method formCreditor has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formCreditor($Identifier = '', $CreditorId = '')
    {

        // choose between Add and Edit
        $SaveButton = new Primary('Speichern', self::getEndpoint(), new Save());
    Severity: Major
    Found in Application/Api/Billing/Accounting/ApiCreditor.php - About 2 hrs to fix

      Method showDeleteCreditor has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function showDeleteCreditor($Identifier = '', $CreditorId = '')
    {

        $tblCreditor = Creditor::useService()->getCreditorById($CreditorId);
      Severity: Minor
      Found in Application/Api/Billing/Accounting/ApiCreditor.php - About 1 hr to fix

        Method checkInputCreditor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function checkInputCreditor($Identifier = '', $CreditorId = '', $Creditor = array())
    {
        $Error = false;
        $form = $this->formCreditor($Identifier, $CreditorId);
        if(isset($Creditor['Owner']) && empty($Creditor['Owner'])){
        Severity: Minor
        Found in Application/Api/Billing/Accounting/ApiCreditor.php - About 1 hr to fix

          Function checkInputCreditor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function checkInputCreditor($Identifier = '', $CreditorId = '', $Creditor = array())
    {
        $Error = false;
        $form = $this->formCreditor($Identifier, $CreditorId);
        if(isset($Creditor['Owner']) && empty($Creditor['Owner'])){
          Severity: Minor
          Found in Application/Api/Billing/Accounting/ApiCreditor.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if($form = $this->checkInputCreditor($Identifier, $CreditorId, $Creditor)){
            // display Errors on form
            $Global = $this->getGlobal();
            $Global->POST['Creditor']['Owner'] = $Creditor['Owner'];
            $Global->POST['Creditor']['Street'] = $Creditor['Street'];
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 1 other location - About 7 hrs to fix
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 398..413

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 230.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if($form = $this->checkInputCreditor($Identifier, '', $Creditor)){
            // display Errors on form
            $Global = $this->getGlobal();
            $Global->POST['Creditor']['Owner'] = $Creditor['Owner'];
            $Global->POST['Creditor']['Street'] = $Creditor['Street'];
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 1 other location - About 7 hrs to fix
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 437..452

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 230.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function pipelineOpenEditCreditorModal($Identifier = '', $CreditorId = '', $Creditor = array())
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline(true);
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 1 other location - About 2 hrs to fix
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 175..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 136.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public static function pipelineSaveEditCreditor($Identifier = '', $CreditorId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline(true);
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 3 other locations - About 2 hrs to fix
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 203..219
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 449..465
          Application/Api/Billing/Inventory/ApiItem.php on lines 190..206

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 124.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 14 locations. Consider refactoring.
          Open

              public static function pipelineOpenDeleteCreditorModal($Identifier = '', $CreditorId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 13 other locations - About 1 hr to fix
          Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
          Application/Api/Billing/Accounting/ApiBankReference.php on lines 125..141
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 213..229
          Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
          Application/Api/Billing/Inventory/ApiItem.php on lines 214..230
          Application/Api/Billing/Inventory/ApiItem.php on lines 238..254
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
          Application/Api/Billing/Inventory/ItemVariant.php on lines 148..164
          Application/Api/Billing/Inventory/ItemVariant.php on lines 172..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 14 locations. Consider refactoring.
          Open

              public static function pipelineDeleteCreditor($Identifier = '', $CreditorId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 13 other locations - About 1 hr to fix
          Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
          Application/Api/Billing/Accounting/ApiBankReference.php on lines 125..141
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 189..205
          Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
          Application/Api/Billing/Inventory/ApiItem.php on lines 214..230
          Application/Api/Billing/Inventory/ApiItem.php on lines 238..254
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
          Application/Api/Billing/Inventory/ItemVariant.php on lines 148..164
          Application/Api/Billing/Inventory/ItemVariant.php on lines 172..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      return new Layout(
                new LayoutGroup(
                    new LayoutRow(array(
                        new LayoutColumn(
                            new Panel('Soll der Gläubiger wirklich entfernt werden?'
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 1 other location - About 1 hr to fix
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 952..967

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static function pipelineCloseModal($Identifier = '')
    {
        $Pipeline = new Pipeline();
        // reload the whole Table
        $Emitter = new ServerEmitter(self::receiverCreditorTable(''), self::getEndpoint());
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 2 other locations - About 1 hr to fix
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 318..329
          Application/Api/Billing/Inventory/ApiItem.php on lines 261..272

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static function pipelineSaveAddCreditor($Identifier = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Accounting/ApiCreditor.php and 2 other locations - About 1 hr to fix
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 150..166
          Application/Api/Billing/Inventory/ApiItem.php on lines 139..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status