Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Billing/Balance/BalanceDownload.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function downloadBalanceList has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadBalanceList($ItemIdString = '', $Year = '', $From = '', $To = '', $DivisionId = '', $GroupId = '', $PersonId = '')
    {

        if($ItemIdString){
            $ItemIdList = explode(",", $ItemIdString);
Severity: Minor
Found in Application/Api/Billing/Balance/BalanceDownload.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method downloadBalanceList has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function downloadBalanceList($ItemIdString = '', $Year = '', $From = '', $To = '', $DivisionId = '', $GroupId = '', $PersonId = '')
    {

        if($ItemIdString){
            $ItemIdList = explode(",", $ItemIdString);
Severity: Minor
Found in Application/Api/Billing/Balance/BalanceDownload.php - About 1 hr to fix

    Method downloadBalanceList has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function downloadBalanceList($ItemIdString = '', $Year = '', $From = '', $To = '', $DivisionId = '', $GroupId = '', $PersonId = '')
    Severity: Major
    Found in Application/Api/Billing/Balance/BalanceDownload.php - About 50 mins to fix

      There are no issues that match your filters.

      Category
      Status