Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Billing/Inventory/ApiItem.php

Summary

Maintainability
F
5 days
Test Coverage

File ApiItem.php has 458 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Api\Billing\Inventory;

use SPHERE\Application\Api\ApiTrait;
use SPHERE\Application\Api\Dispatcher;
Severity: Minor
Found in Application/Api/Billing/Inventory/ApiItem.php - About 7 hrs to fix

    Method formItem has 113 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formItem($Identifier = '', $ItemId = '')
    {

        $CheckboxList = array();
        $tblGroupList = array();
    Severity: Major
    Found in Application/Api/Billing/Inventory/ApiItem.php - About 4 hrs to fix

      Function formItem has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function formItem($Identifier = '', $ItemId = '')
    {

        $CheckboxList = array();
        $tblGroupList = array();
      Severity: Minor
      Found in Application/Api/Billing/Inventory/ApiItem.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function saveEditItem has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function saveEditItem($Identifier = '', $ItemId = '', $Item = array(), $Group = array())
    {

        // Handle error's
        if($form = $this->checkInputItem($Identifier, $ItemId, $Item, $Group)){
      Severity: Minor
      Found in Application/Api/Billing/Inventory/ApiItem.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method saveEditItem has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function saveEditItem($Identifier = '', $ItemId = '', $Item = array(), $Group = array())
    {

        // Handle error's
        if($form = $this->checkInputItem($Identifier, $ItemId, $Item, $Group)){
      Severity: Minor
      Found in Application/Api/Billing/Inventory/ApiItem.php - About 1 hr to fix

        Function showEditItem has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function showEditItem($Identifier = '', $ItemId = '')
    {

        if('' !== $ItemId && ($tblItem = Item::useService()->getItemById($ItemId))){
            $Global = $this->getGlobal();
        Severity: Minor
        Found in Application/Api/Billing/Inventory/ApiItem.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkInputItem has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function checkInputItem($Identifier = '', $ItemId = '', $Item = array(), $Group = array())
    {
        $Error = false;
        $form = $this->formItem($Identifier, $ItemId);
        $Warning = '';
        Severity: Minor
        Found in Application/Api/Billing/Inventory/ApiItem.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function showDeleteItem has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function showDeleteItem($Identifier = '', $ItemId = '')
    {

        $tblItem = Item::useService()->getItemById($ItemId);
        $GroupArray = array();
        Severity: Minor
        Found in Application/Api/Billing/Inventory/ApiItem.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method showDeleteItem has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function showDeleteItem($Identifier = '', $ItemId = '')
    {

        $tblItem = Item::useService()->getItemById($ItemId);
        $GroupArray = array();
        Severity: Minor
        Found in Application/Api/Billing/Inventory/ApiItem.php - About 1 hr to fix

          Function saveAddItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function saveAddItem($Identifier = '', $Item = array(), $Group = array())
    {

        // Handle error's
        if($form = $this->checkInputItem($Identifier, '', $Item, $Group)){
          Severity: Minor
          Found in Application/Api/Billing/Inventory/ApiItem.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if($form = $this->checkInputItem($Identifier, '', $Item, $Group)){
            // display Errors on form
            $Global = $this->getGlobal();
            $Global->POST['Item']['Name'] = $Item['Name'];
            $Global->POST['Group'] = $Group;
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 1 other location - About 5 hrs to fix
          Application/Api/Billing/Inventory/ApiItem.php on lines 524..538

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 201.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if($form = $this->checkInputItem($Identifier, $ItemId, $Item, $Group)){
            // display Errors on form
            $Global = $this->getGlobal();
            $Global->POST['Item']['Name'] = $Item['Name'];
            $Global->POST['Group'] = $Group;
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 1 other location - About 5 hrs to fix
          Application/Api/Billing/Inventory/ApiItem.php on lines 482..496

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 201.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function pipelineOpenAddItemModal($Identifier = '', $Item = array(), $Group = array())
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 1 other location - About 2 hrs to fix
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 126..143

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 131.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public static function pipelineSaveEditItem($Identifier = '', $ItemId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline(true);
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 3 other locations - About 2 hrs to fix
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 165..181
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 203..219
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 449..465

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 124.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 14 locations. Consider refactoring.
          Open

              public static function pipelineDeleteItem($Identifier = '', $ItemId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 13 other locations - About 1 hr to fix
          Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
          Application/Api/Billing/Accounting/ApiBankReference.php on lines 125..141
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 189..205
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 213..229
          Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
          Application/Api/Billing/Inventory/ApiItem.php on lines 214..230
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
          Application/Api/Billing/Inventory/ItemVariant.php on lines 148..164
          Application/Api/Billing/Inventory/ItemVariant.php on lines 172..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 14 locations. Consider refactoring.
          Open

              public static function pipelineOpenDeleteItemModal($Identifier = '', $ItemId = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 13 other locations - About 1 hr to fix
          Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
          Application/Api/Billing/Accounting/ApiBankReference.php on lines 125..141
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 189..205
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 213..229
          Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
          Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
          Application/Api/Billing/Inventory/ApiItem.php on lines 238..254
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
          Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
          Application/Api/Billing/Inventory/ItemVariant.php on lines 148..164
          Application/Api/Billing/Inventory/ItemVariant.php on lines 172..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static function pipelineCloseModal($Identifier = '')
    {
        $Pipeline = new Pipeline();
        // reload the whole Table
        $Emitter = new ServerEmitter(self::receiverItemTable(''), self::getEndpoint());
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 2 other locations - About 1 hr to fix
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 236..247
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 318..329

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static function pipelineSaveAddItem($Identifier = '')
    {

        $Receiver = self::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
          Severity: Major
          Found in Application/Api/Billing/Inventory/ApiItem.php and 2 other locations - About 1 hr to fix
          Application/Api/Billing/Accounting/ApiCreditor.php on lines 116..131
          Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 150..166

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status