Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Billing/Inventory/ItemVariant.php

Summary

Maintainability
F
3 days
Test Coverage

Function checkInputVariant has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private function checkInputVariant($Identifier, $ItemId, $VariantId, $Variant = array(), $Calculation = array())
    {
        $Error = false;
        $form = $this->formVariant($Identifier, $ItemId, $VariantId);
Severity: Minor
Found in Application/Api/Billing/Inventory/ItemVariant.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ItemVariant.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Api\Billing\Inventory;

use SPHERE\Application\Billing\Inventory\Item\Item;
use SPHERE\Common\Frontend\Ajax\Emitter\ServerEmitter;
Severity: Minor
Found in Application/Api/Billing/Inventory/ItemVariant.php - About 3 hrs to fix

    Method formVariant has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formVariant($Identifier, $ItemId, $VariantId = '')
    {

        // choose between Add and Edit
        $SaveButton = new Primary('Speichern', ApiItem::getEndpoint(), new Save());
    Severity: Minor
    Found in Application/Api/Billing/Inventory/ItemVariant.php - About 1 hr to fix

      Method checkInputVariant has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function checkInputVariant($Identifier, $ItemId, $VariantId, $Variant = array(), $Calculation = array())
    {
        $Error = false;
        $form = $this->formVariant($Identifier, $ItemId, $VariantId);
      Severity: Minor
      Found in Application/Api/Billing/Inventory/ItemVariant.php - About 1 hr to fix

        Method showDeleteVariant has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function showDeleteVariant($Identifier = '', $VariantId = '')
    {

        $tblItemVariant = Item::useService()->getItemVariantById($VariantId);
        if($tblItemVariant){
        Severity: Minor
        Found in Application/Api/Billing/Inventory/ItemVariant.php - About 1 hr to fix

          Function showDeleteVariant has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function showDeleteVariant($Identifier = '', $VariantId = '')
    {

        $tblItemVariant = Item::useService()->getItemVariantById($VariantId);
        if($tblItemVariant){
          Severity: Minor
          Found in Application/Api/Billing/Inventory/ItemVariant.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method checkInputVariant has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function checkInputVariant($Identifier, $ItemId, $VariantId, $Variant = array(), $Calculation = array())
          Severity: Minor
          Found in Application/Api/Billing/Inventory/ItemVariant.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function pipelineSaveEditVariant($Identifier, $ItemId, $VariantId)
    {

        $Receiver = ApiItem::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline(true);
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 1 other location - About 2 hrs to fix
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 124..141

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if($form = $this->checkInputVariant($Identifier, $ItemId, '', $Variant, $Calculation)){
            // display Errors on form
            $Global = $this->getGlobal();
            $Global->POST['Variant']['Name'] = $Variant['Name'];
            $Global->POST['Variant']['Description'] = $Variant['Description'];
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 1 other location - About 2 hrs to fix
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 754..764

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function pipelineOpenEditVariantModal($Identifier, $ItemId, $VariantId)
    {

        $Receiver = ApiItem::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 1 other location - About 2 hrs to fix
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 98..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 123.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 14 locations. Consider refactoring.
            Open

                public static function pipelineDeleteVariant($Identifier = '', $VariantId = '')
    {

        $Receiver = ApiItem::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 13 other locations - About 1 hr to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
            Application/Api/Billing/Accounting/ApiBankReference.php on lines 125..141
            Application/Api/Billing/Accounting/ApiCreditor.php on lines 189..205
            Application/Api/Billing/Accounting/ApiCreditor.php on lines 213..229
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
            Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
            Application/Api/Billing/Inventory/ApiItem.php on lines 214..230
            Application/Api/Billing/Inventory/ApiItem.php on lines 238..254
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
            Application/Api/Billing/Inventory/ItemVariant.php on lines 148..164

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 14 locations. Consider refactoring.
            Open

                public static function pipelineOpenDeleteVariantModal($Identifier = '', $VariantId = '')
    {

        $Receiver = ApiItem::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 13 other locations - About 1 hr to fix
            Application/Api/Billing/Accounting/ApiBankAccount.php on lines 121..137
            Application/Api/Billing/Accounting/ApiBankReference.php on lines 125..141
            Application/Api/Billing/Accounting/ApiCreditor.php on lines 189..205
            Application/Api/Billing/Accounting/ApiCreditor.php on lines 213..229
            Application/Api/Billing/Accounting/ApiDebtor.php on lines 128..144
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 227..243
            Application/Api/Billing/Bookkeeping/ApiBasket.php on lines 251..267
            Application/Api/Billing/Bookkeeping/ApiBasketVerification.php on lines 425..441
            Application/Api/Billing/Inventory/ApiItem.php on lines 214..230
            Application/Api/Billing/Inventory/ApiItem.php on lines 238..254
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 149..165
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 173..189
            Application/Api/Billing/Inventory/ItemVariant.php on lines 172..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public static function pipelineOpenAddVariantModal($Identifier, $ItemId)
    {

        $Receiver = ApiItem::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 3 other locations - About 1 hr to fix
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 49..65
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 73..89
            Application/Api/Billing/Inventory/ItemVariant.php on lines 72..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public static function pipelineSaveAddVariant($Identifier, $ItemId)
    {

        $Receiver = ApiItem::receiverModal(null, $Identifier);
        $Pipeline = new Pipeline();
            Severity: Major
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 3 other locations - About 1 hr to fix
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 49..65
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 73..89
            Application/Api/Billing/Inventory/ItemVariant.php on lines 48..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if(isset($Calculation['Value']) && empty($Calculation['Value']) && $Calculation['Value'] !== '0'){
                    $form->setError('Calculation[Value]', 'Bitte geben Sie einen Preis an');
                    $Error = true;
                } elseif(isset($Calculation['Value']) && $Calculation['Value'] < 0) {
                    $form->setError('Calculation[Value]', 'Bitte geben Sie einen Preis im positiven Bereich an');
            Severity: Minor
            Found in Application/Api/Billing/Inventory/ItemVariant.php and 1 other location - About 55 mins to fix
            Application/Api/Billing/Inventory/ItemCalculation.php on lines 260..266

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status