Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Contact/ApiAddressToCompany.php

Summary

Maintainability
D
2 days
Test Coverage

File ApiAddressToCompany.php has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 07.01.2019
Severity: Minor
Found in Application/Api/Contact/ApiAddressToCompany.php - About 3 hrs to fix

    Method openDeleteAddressToCompanyModal has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function openDeleteAddressToCompanyModal($CompanyId, $ToCompanyId)
    {

        if (!($tblCompany = Company::useService()->getCompanyById($CompanyId))) {
            return new Danger('Die Company wurde nicht gefunden', new Exclamation());
    Severity: Minor
    Found in Application/Api/Contact/ApiAddressToCompany.php - About 1 hr to fix

      Method getAddressToCompanyModal has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getAddressToCompanyModal($form, TblCompany $tblCompany,  $ToCompanyId = null)
    {
        if ($ToCompanyId) {
            $title = new Title(new Edit() . ' Adresse bearbeiten');
        } else {
      Severity: Minor
      Found in Application/Api/Contact/ApiAddressToCompany.php - About 1 hr to fix

        Method saveEditAddressToCompanyModal has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function saveEditAddressToCompanyModal($CompanyId, $ToCompanyId, $Street, $City, $State, $Type, $County, $Nation)
        Severity: Major
        Found in Application/Api/Contact/ApiAddressToCompany.php - About 1 hr to fix

          Method saveCreateAddressToCompanyModal has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function saveCreateAddressToCompanyModal($CompanyId, $Street, $City, $State, $Type, $County, $Nation)
          Severity: Major
          Found in Application/Api/Contact/ApiAddressToCompany.php - About 50 mins to fix

            Avoid too many return statements within this method.
            Open

                        return new Danger('Die Adresse konnte nicht gespeichert werden.') . self::pipelineClose();
            Severity: Major
            Found in Application/Api/Contact/ApiAddressToCompany.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function openDeleteAddressToCompanyModal($CompanyId, $ToCompanyId)
    {

        if (!($tblCompany = Company::useService()->getCompanyById($CompanyId))) {
            return new Danger('Die Company wurde nicht gefunden', new Exclamation());
              Severity: Major
              Found in Application/Api/Contact/ApiAddressToCompany.php and 1 other location - About 1 day to fix
              Application/Api/Contact/ApiAddressToPerson.php on lines 481..515

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 342.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status