Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Contact/ApiContactAddress.php

Summary

Maintainability
D
1 day
Test Coverage

File ApiContactAddress.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Api\Contact;

use SPHERE\Application\Api\ApiTrait;
Severity: Minor
Found in Application/Api/Contact/ApiContactAddress.php - About 2 hrs to fix

    Method formAddress has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function formAddress($PersonId)
    {

        $tblAddress = Address::useService()->getAddressAll();
        $tblCity = Address::useService()->getCityAll();
    Severity: Major
    Found in Application/Api/Contact/ApiContactAddress.php - About 2 hrs to fix

      Method openModal has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function openModal($PersonId)
    {

        $tblPerson = Person::useService()->getPersonById($PersonId);
        if (!$tblPerson) {
      Severity: Minor
      Found in Application/Api/Contact/ApiContactAddress.php - About 1 hr to fix

        Method saveModal has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $PersonId,
        $Type,
        $Street,
        $City,
        $County,
        Severity: Major
        Found in Application/Api/Contact/ApiContactAddress.php - About 50 mins to fix

          Function openModal has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function openModal($PersonId)
    {

        $tblPerson = Person::useService()->getPersonById($PersonId);
        if (!$tblPerson) {
          Severity: Minor
          Found in Application/Api/Contact/ApiContactAddress.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkInputAddress has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function checkInputAddress($PersonId, $Street = array(), $City = array())
    {
        $Error = false;
        $form = $this->formAddress($PersonId);
        if (isset($Street['Name']) && empty($Street['Name'])) {
          Severity: Minor
          Found in Application/Api/Contact/ApiContactAddress.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              new FormColumn(
                        new Panel('Stadt', array(
                            (new AutoCompleter('City[Code]', 'Postleitzahl', 'Postleitzahl',
                                array('Code' => $tblCity), new MapMarker()
                            ))->setRequired(),
          Severity: Major
          Found in Application/Api/Contact/ApiContactAddress.php and 2 other locations - About 7 hrs to fix
          Application/Contact/Address/Frontend.php on lines 127..148
          Application/Contact/Address/Frontend.php on lines 238..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 225.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status