Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Contact/ApiPhoneToPerson.php

Summary

Maintainability
F
1 wk
Test Coverage

File ApiPhoneToPerson.php has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 08.01.2019
Severity: Minor
Found in Application/Api/Contact/ApiPhoneToPerson.php - About 3 hrs to fix

    Method openDeletePhoneToPersonModal has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function openDeletePhoneToPersonModal($PersonId, $ToPersonId)
    {

        if (!($tblPerson = Person::useService()->getPersonById($PersonId))) {
            return new Danger('Die Person wurde nicht gefunden', new Exclamation());
    Severity: Minor
    Found in Application/Api/Contact/ApiPhoneToPerson.php - About 1 hr to fix

      Method getPhoneToPersonModal has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getPhoneToPersonModal($form, TblPerson $tblPerson,  $ToPersonId = null)
    {
        if ($ToPersonId) {
            $title = new Title(new Edit() . ' Telefonnummer bearbeiten');
        } else {
      Severity: Minor
      Found in Application/Api/Contact/ApiPhoneToPerson.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return new Danger('Die Telefonnummer konnte nicht gespeichert werden.') . self::pipelineClose();
        Severity: Major
        Found in Application/Api/Contact/ApiPhoneToPerson.php - About 30 mins to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          <?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 08.01.2019
          Severity: Major
          Found in Application/Api/Contact/ApiPhoneToPerson.php and 4 other locations - About 1 wk to fix
          Application/Api/Contact/ApiMailToCompany.php on lines 1..482
          Application/Api/Contact/ApiMailToPerson.php on lines 1..477
          Application/Api/Contact/ApiPhoneToCompany.php on lines 1..477
          Application/Api/Contact/ApiWebToCompany.php on lines 1..482

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 2247.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status