Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Contact/ApiRelationshipToPerson.php

Summary

Maintainability
F
4 days
Test Coverage

File ApiRelationshipToPerson.php has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 04.01.2019
Severity: Minor
Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 6 hrs to fix

    Function loadExtraOptions has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadExtraOptions($PersonId, $Type, $To)
    {
        $isChild = $Type['Type'] == TblType::CHILD_ID;
        if ($isChild
            || (($tblType = Relationship::useService()->getTypeById($Type['Type']))
    Severity: Minor
    Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    ApiRelationshipToPerson has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ApiRelationshipToPerson  extends Extension implements IApiInterface
{

    use ApiTrait;
    Severity: Minor
    Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 2 hrs to fix

      Method loadExtraOptions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function loadExtraOptions($PersonId, $Type, $To)
    {
        $isChild = $Type['Type'] == TblType::CHILD_ID;
        if ($isChild
            || (($tblType = Relationship::useService()->getTypeById($Type['Type']))
      Severity: Minor
      Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 1 hr to fix

        Method openDeleteRelationshipToPersonModal has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function openDeleteRelationshipToPersonModal($PersonId, $ToPersonId)
    {

        if (!($tblPerson = Person::useService()->getPersonById($PersonId))) {
            return new Danger('Die Person wurde nicht gefunden', new Exclamation());
        Severity: Minor
        Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 1 hr to fix

          Method getRelationshipToPersonModal has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getRelationshipToPersonModal($form, TblPerson $tblPerson,  $ToPersonId = null)
    {
        if ($ToPersonId) {
            $title = new Title(new Edit() . ' Personenbeziehung bearbeiten');
        } else {
          Severity: Minor
          Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 1 hr to fix

            Function getPostForGender has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getPostForGender($genderSetting, $genderName)
    {

        $post = null;
        if ($genderName == 'Weiblich') {
            Severity: Minor
            Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method saveEditRelationshipToPersonModal has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function saveEditRelationshipToPersonModal($PersonId, $ToPersonId, $Type, $To, $Search)
            Severity: Minor
            Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                          return new Danger('Die Personenbeziehung konnte nicht gespeichert werden.') . self::pipelineClose();
              Severity: Major
              Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new Danger('Die Personenbeziehung konnte nicht gespeichert werden.') . self::pipelineClose();
                Severity: Major
                Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new Success('Die Personenbeziehung wurde erfolgreich gespeichert.')
                . self::pipelineLoadRelationshipToPersonContent($PersonId)
                . ApiAddressToPerson::pipelineLoadAddressToPersonContent($PersonId)
                . ApiPhoneToPerson::pipelineLoadPhoneToPersonContent($PersonId)
                . ApiMailToPerson::pipelineLoadMailToPersonContent($PersonId)
                  Severity: Major
                  Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 30 mins to fix

                    Function saveEditRelationshipToPersonModal has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function saveEditRelationshipToPersonModal($PersonId, $ToPersonId, $Type, $To, $Search)
    {

        if (!($tblPersonFrom = Person::useService()->getPersonById($PersonId))) {
            return new Danger('Die Person wurde nicht gefunden', new Exclamation());
                    Severity: Minor
                    Found in Application/Api/Contact/ApiRelationshipToPerson.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function openDeleteRelationshipToPersonModal($PersonId, $ToPersonId)
    {

        if (!($tblPerson = Person::useService()->getPersonById($PersonId))) {
            return new Danger('Die Person wurde nicht gefunden', new Exclamation());
                    Severity: Major
                    Found in Application/Api/Contact/ApiRelationshipToPerson.php and 1 other location - About 1 day to fix
                    Application/Api/Contact/ApiRelationshipToCompany.php on lines 392..426

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 347.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function exportApi($Method = '')
    {
        $Dispatcher = new Dispatcher(__CLASS__);

        $Dispatcher->registerMethod('loadRelationshipToPersonContent');
                    Severity: Major
                    Found in Application/Api/Contact/ApiRelationshipToPerson.php and 1 other location - About 1 hr to fix
                    Application/Api/Platform/Gatekeeper/ApiUserGroup.php on lines 57..77

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 114.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status