Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Document/Standard/Repository/Billing/Billing.php

Summary

Maintainability
F
3 days
Test Coverage

Method buildPage has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildPage(
        TblPerson $tblPersonDebtor,
        TblPerson $tblPersonCauser,
        $TotalPrice
    ) {
Severity: Major
Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 4 hrs to fix

    File Billing.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 13.03.2019
    Severity: Minor
    Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 2 hrs to fix

      Method setPlaceholders has 18 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $Text,
        $ItemName,
        $Year,
        $TotalPrice,
        $DebtorSalutation,
      Severity: Major
      Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 2 hrs to fix

        Method getAddressSlice has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getAddressSlice(
        $CompanyName,
        $CompanyExtendedName,
        $CompanyAddress,
        TblPerson $tblPersonDebtor,
        Severity: Minor
        Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 1 hr to fix

          Method getAddressSlice has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $CompanyName,
        $CompanyExtendedName,
        $CompanyAddress,
        TblPerson $tblPersonDebtor,
        $TextSize = '8px'
          Severity: Minor
          Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 35 mins to fix

            Function buildDocument has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function buildDocument($pageList = array())
    {
        $document = new Document();

        foreach ($pageList as $subjectPages) {
            Severity: Minor
            Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getHeaderSlice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getHeaderSlice($Height = '200px')
    {
        if (($tblSetting = Consumer::useService()->getSetting(
            'Api', 'Document', 'Standard', 'Billing_PictureAddress'))
        ) {
            Severity: Minor
            Found in Application/Api/Document/Standard/Repository/Billing/Billing.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private function getAddressSlice(
        $CompanyName,
        $CompanyExtendedName,
        $CompanyAddress,
        TblPerson $tblPersonDebtor,
            Severity: Major
            Found in Application/Api/Document/Standard/Repository/Billing/Billing.php and 1 other location - About 1 day to fix
            Application/Api/Document/Standard/Repository/Billing/DocumentWarning.php on lines 306..353

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 344.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private function getHeaderSlice($Height = '200px')
    {
        if (($tblSetting = Consumer::useService()->getSetting(
            'Api', 'Document', 'Standard', 'Billing_PictureAddress'))
        ) {
            Severity: Major
            Found in Application/Api/Document/Standard/Repository/Billing/Billing.php and 1 other location - About 5 hrs to fix
            Application/Api/Document/Standard/Repository/Billing/DocumentWarning.php on lines 265..295

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 194.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private function buildDocument($pageList = array())
    {
        $document = new Document();

        foreach ($pageList as $subjectPages) {
            Severity: Minor
            Found in Application/Api/Document/Standard/Repository/Billing/Billing.php and 1 other location - About 30 mins to fix
            Application/Api/Document/Standard/Repository/Billing/DocumentWarning.php on lines 62..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status