Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php

Summary

Maintainability
F
1 wk
Test Coverage

Function getGradebookOverviewSlice has a Cognitive Complexity of 286 (exceeds 5 allowed). Consider refactoring.
Open

    public function getGradebookOverviewSlice()
    {

        if ($this->getTblDivision()
            && ($tblPerson = $this->getTblPerson())
Severity: Minor
Found in Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getGradebookOverviewSlice has 314 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getGradebookOverviewSlice()
    {

        if ($this->getTblDivision()
            && ($tblPerson = $this->getTblPerson())
Severity: Major
Found in Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php - About 1 day to fix

    File GradebookOverview.php has 408 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace SPHERE\Application\Api\Document\Standard\Repository\GradebookOverview;

use SPHERE\Application\Api\Document\AbstractDocument;
    Severity: Minor
    Found in Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php - About 5 hrs to fix

      Method getPageHeaderSlice has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPageHeaderSlice()
    {
        return (new Slice())
            ->addSection((new Section())
                ->addSliceColumn((new Slice())
      Severity: Minor
      Found in Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                        if ($hasStudentSubject) {
                                    if ($tblPeriodList
                                        && ($tblTestType = Evaluation::useService()->getTestTypeByIdentifier('TEST'))
                                    ) {
                                        $tblScoreRule = Gradebook::useService()->getScoreRuleByDivisionAndSubjectAndGroup(
        Severity: Major
        Found in Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                                  if (Division::useService()->getSubjectStudentByDivisionSubjectAndPerson($tblDivisionSubjectGroup,
                                            $tblPerson)
                                        ) {
                                            $hasStudentSubject = true;
                                        }
          Severity: Major
          Found in Application/Api/Document/Standard/Repository/GradebookOverview/GradebookOverview.php - About 45 mins to fix

            There are no issues that match your filters.

            Category
            Status