DerDu/SPHERE-Framework

View on GitHub
Application/Api/Document/Standard/Repository/StudentCard/AbstractStudentCard.php

Summary

Maintainability
F
6 days
Test Coverage

File AbstractStudentCard.php has 533 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 08.03.2017

    Method buildRemarkPage has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function buildRemarkPage(TblType $tblType = null)
        {
            $textSize = '11px';
            $textSizeSmall = '9px';
            $height = '15px';

      Method setGradeLayoutBody has 139 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setGradeLayoutBody(
              $subjectPosition = array(),
              $typeId = 0,
              $countSubjectColumns = 18,
              $countRows = 12,

        Function setGradeLayoutBody has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function setGradeLayoutBody(
                $subjectPosition = array(),
                $typeId = 0,
                $countSubjectColumns = 18,
                $countRows = 12,

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setGradeLayoutHeader has 114 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function setGradeLayoutHeader(
                &$subjectPosition = array(),
                $countSubjectColumns = 18,
                $widthFirstColumns = 6,
                $widthLastColumns = 5,

          Function setLetterRow has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function setLetterRow($textSize = '16px')
              {
          
                  $countCharacters = 26;
                  $width = (100/$countCharacters) . '%';

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setGradeLayoutHeader has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function setGradeLayoutHeader(
                  &$subjectPosition = array(),
                  $countSubjectColumns = 18,
                  $widthFirstColumns = 6,
                  $widthLastColumns = 5,

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getNextSubject has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getNextSubject($tblDocument, $tblSubjectList, &$pointer)
              {
                  if ($pointer > 30) {
                      return false;
                  }

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setLetterRow has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function setLetterRow($textSize = '16px')
              {
          
                  $countCharacters = 26;
                  $width = (100/$countCharacters) . '%';

            Method setGradeLayoutBody has 12 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $subjectPosition = array(),
                    $typeId = 0,
                    $countSubjectColumns = 18,
                    $countRows = 12,
                    $breakRow = false,

              Method setGradeLayoutHeader has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      &$subjectPosition = array(),
                      $countSubjectColumns = 18,
                      $widthFirstColumns = 6,
                      $widthLastColumns = 5,
                      $heightHeader = '150px',

                Method getNextSubject has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function getNextSubject($tblDocument, $tblSubjectList, &$pointer)
                    {
                        if ($pointer > 30) {
                            return false;
                        }

                  Function buildRemarkPage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function buildRemarkPage(TblType $tblType = null)
                      {
                          $textSize = '11px';
                          $textSizeSmall = '9px';
                          $height = '15px';

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                          return false;

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    } elseif ($i >= 8 && $i <= (3 + $countGradesTotal)) {
                                        $thicknessLeft = $i == 8 ? $thicknessOutLines : $thicknessInnerLines;
                                        $widthColumn = $widthString;
                                        if (isset($subjectPosition[$i - 7])) {
                                            $tblSubject = $subjectPosition[$i - 7];
                    Application/Api/Document/Standard/Repository/StudentCard/GrammarSchool.php on lines 483..497

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 145.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                ->addSlice((new Slice())
                                    ->styleBorderLeft($thicknessOuterLines)
                                    ->styleBorderTop($thicknessOuterLines)
                                    ->styleBorderRight($thicknessOuterLines)
                                    ->styleBorderBottom($thicknessOuterLines)
                    Application/Api/Document/Standard/Repository/StudentCard/AbstractStudentCard.php on lines 565..639

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 141.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            for ($i = 1; $i <= 3; $i++) {
                                $text = '&nbsp;';
                                switch ($i) {
                                    case 1: $text = 'Klasse'; break;
                                    case 2: $text = 'Schuljahr'; break;
                    Application/Api/Document/Standard/Repository/StudentCard/GrammarSchool.php on lines 342..356

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 134.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status