DerDu/SPHERE-Framework

View on GitHub
Application/Api/Document/Standard/Repository/StudentTransfer/StudentTransfer.php

Summary

Maintainability
F
4 days
Test Coverage

File StudentTransfer.php has 575 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Api\Document\Standard\Repository\StudentTransfer;

use SPHERE\Application\Api\Document\AbstractDocument;

    Method getStudentTransferHead has 125 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getStudentTransferHead()
        {
            $Slice = new Slice();
            $Slice->addElement((new Element())
                ->setContent('Abgebende Schule')

      Method buildPage has 100 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function buildPage()
          {
              return (new Page())
                  ->addSlice((new Slice())
                      ->addSection((new Section())

        Method getStudentTransferNewSchool has 84 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getStudentTransferNewSchool()
            {
                $Slice = new Slice();
                $Slice->addSection((new Section())
                    ->addSliceColumn((new Slice())

          Method getStudentTransferStudent has 78 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getStudentTransferStudent()
              {
          
                  if ($this->FieldValue['Gender'] == 'Männlich') {
                      $GenderString = 'des Schülers';

            Method getStudentTransferStudentDivision has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function getStudentTransferStudentDivision()
                {
            
                    $Slice = new Slice();
                    $Slice->addSection((new Section())

              Method getStudentTransferFooter has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function getStudentTransferFooter()
                  {
              
                      $Slice = new Slice();
                      $Slice->addElement((new Element())

                Function setFieldValue has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function setFieldValue($DataPost)
                    {
                
                        // PersonGender
                        $this->FieldValue['Gender'] = '';

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method setFieldValue has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function setFieldValue($DataPost)
                    {
                
                        // PersonGender
                        $this->FieldValue['Gender'] = '';

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $Slice->addSection((new Section())
                              ->addElementColumn((new Element())
                                  ->setContent($this->FieldValue['SchoolEntry'])
                                  ->stylePaddingLeft($this->TextPaddingLeft)
                                  ->styleBorderLeft()
                  Application/Api/Document/Standard/Repository/StudentTransfer/StudentTransfer.php on lines 173..198

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 143.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $Slice->addSection((new Section())
                              ->addElementColumn((new Element())
                                  ->setContent($this->FieldValue['ContactPerson'])
                                  ->stylePaddingLeft($this->TextPaddingLeft)
                                  ->styleBorderLeft()
                  Application/Api/Document/Standard/Repository/StudentTransfer/StudentTransfer.php on lines 469..494

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 143.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if ($this->FieldValue['PersonId'] && ($tblPerson = Person::useService()->getPersonById($this->FieldValue['PersonId']))) {
                              if (($tblCommon = Common::useService()->getCommonByPerson($tblPerson))) {
                                  if (($tblCommonBirthDates = $tblCommon->getTblCommonBirthDates())) {
                                      if (($tblGender = $tblCommonBirthDates->getTblCommonGender())) {
                                          $this->FieldValue['Gender'] = $tblGender->getName();
                  Application/Api/Document/Standard/Repository/SignOutCertificate/SignOutCertificate.php on lines 55..63

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 94.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status