Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Education/Division/StudentGroupSelect.php

Summary

Maintainability
F
1 wk
Test Coverage

Function tablePerson has a Cognitive Complexity of 228 (exceeds 5 allowed). Consider refactoring.
Open

    public static function tablePerson($DivisionSubjectId = null)
    {

        // get Content
        $tblDivisionSubject = DivisionApplication::useService()->getDivisionSubjectById($DivisionSubjectId);
Severity: Minor
Found in Application/Api/Education/Division/StudentGroupSelect.php - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tablePerson has 241 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function tablePerson($DivisionSubjectId = null)
    {

        // get Content
        $tblDivisionSubject = DivisionApplication::useService()->getDivisionSubjectById($DivisionSubjectId);
Severity: Major
Found in Application/Api/Education/Division/StudentGroupSelect.php - About 1 day to fix

    File StudentGroupSelect.php has 373 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Api\Education\Division;

use SPHERE\Application\Api\ApiTrait;
use SPHERE\Application\Api\Dispatcher;
    Severity: Minor
    Found in Application/Api/Education/Division/StudentGroupSelect.php - About 4 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                                          if (($tblSubject = $tblDivisionSubjectItem->getServiceTblSubject())
                                        && ($tblPerson = $tblSubjectStudent->getServiceTblPerson())
                                    ) {
                                        if ($tblSubject->getName() == 'Deutsch' || $tblSubject->getName() == 'Mathematik') {
                                            $personAdvancedCourses[0][$tblPerson->getId()] = $tblSubject->getAcronym();
      Severity: Major
      Found in Application/Api/Education/Division/StudentGroupSelect.php - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static function pipelinePlus($Id = null, $DivisionSubjectId = null)
    {

        $Pipeline = new Pipeline();
        Severity: Major
        Found in Application/Api/Education/Division/StudentGroupSelect.php and 1 other location - About 6 hrs to fix
        Application/Api/Education/Division/StudentGroupSelect.php on lines 419..450

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 212.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static function pipelineMinus($Id = null, $DivisionSubjectId = null)
    {

        $Pipeline = new Pipeline();
        Severity: Major
        Found in Application/Api/Education/Division/StudentGroupSelect.php and 1 other location - About 6 hrs to fix
        Application/Api/Education/Division/StudentGroupSelect.php on lines 476..507

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 212.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status