Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php

Summary

Maintainability
D
2 days
Test Coverage

Function loadTestPlanning has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadTestPlanning($Data = null, $IsDivisionTeacher = null, $PersonId = null)
    {
        $IsDivisionTeacher = $IsDivisionTeacher === 'true';
        if ($Data === null) {
            return '';
Severity: Minor
Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadTestPlanning has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadTestPlanning($Data = null, $IsDivisionTeacher = null, $PersonId = null)
    {
        $IsDivisionTeacher = $IsDivisionTeacher === 'true';
        if ($Data === null) {
            return '';
Severity: Major
Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php - About 3 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return new Layout(new LayoutGroup($preview));
    Severity: Major
    Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return new Warning('Klasse nicht gefunden', new Exclamation());
      Severity: Major
      Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return new Warning('Keine Leistungsüberprüfungen gefunden', new Exclamation());
        Severity: Major
        Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (isset($Data['DivisionName']) && ($divisionName = $Data['DivisionName']) && $divisionName != '') {
            $tblDivisionList = Division::useService()->getDivisionAllByName($divisionName, $tblYear, $tblType ? $tblType : null);
            if (empty($tblDivisionList)) {
                return new Warning('Klasse nicht gefunden', new Exclamation());
            }
          Severity: Major
          Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php and 1 other location - About 2 hrs to fix
          Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php on lines 129..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function pipelineCreateTestPlanningContent(AbstractReceiver $Receiver, $Data, $IsDivisionTeacher, $PersonId)
    {

        $FieldPipeline = new Pipeline(false);
        $FieldEmitter = new ServerEmitter($Receiver, self::getEndpoint());
          Severity: Major
          Found in Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php and 1 other location - About 2 hrs to fix
          Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php on lines 84..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status