Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php

Summary

Maintainability
F
4 days
Test Coverage

Function loadMinimumGradeCountReporting has a Cognitive Complexity of 113 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadMinimumGradeCountReporting($Data = null, $IsDivisionTeacher = null, $PersonId = null)
    {
        ini_set('memory_limit', '2G');

        $IsDivisionTeacher = $IsDivisionTeacher === 'true';
Severity: Minor
Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadMinimumGradeCountReporting has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadMinimumGradeCountReporting($Data = null, $IsDivisionTeacher = null, $PersonId = null)
    {
        ini_set('memory_limit', '2G');

        $IsDivisionTeacher = $IsDivisionTeacher === 'true';
Severity: Major
Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 5 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                            if ($countPersons == 1) {
                                            $minimumPersonCount = $countMinimumGradeByPerson;
                                        } elseif ($countMinimumGradeByPerson < $minimumPersonCount) {
                                            $minimumPersonCount = $countMinimumGradeByPerson;
                                        }
    Severity: Major
    Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                              if ($countMinimumGradeByPerson > $maximumPersonCount) {
                                            $maximumPersonCount = $countMinimumGradeByPerson;
                                        }
      Severity: Major
      Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                                if ($countMinimumGradeByPerson >= $minimumCount) {
                                            $countFulfil++;
                                        }
        Severity: Major
        Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                  return new Warning('Keine Mindestnoten gefunden', new Exclamation());
          Severity: Major
          Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn($panelList))));
            Severity: Major
            Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (isset($Data['DivisionName']) && ($divisionName = $Data['DivisionName']) && $divisionName != '') {
            $tblDivisionList = Division::useService()->getDivisionAllByName($divisionName, $tblYear, $tblType ? $tblType : null);
            if (empty($tblDivisionList)) {
                return new Warning('Klasse nicht gefunden', new Exclamation());
            }
              Severity: Major
              Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php and 1 other location - About 2 hrs to fix
              Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php on lines 136..147

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public static function pipelineCreateMinimumGradeCountReportingContent(AbstractReceiver $Receiver, $Data, $IsDivisionTeacher, $PersonId)
    {

        $FieldPipeline = new Pipeline(false);
        $FieldEmitter = new ServerEmitter($Receiver, self::getEndpoint());
              Severity: Major
              Found in Application/Api/Education/Graduation/Gradebook/ApiMinimumGradeCount.php and 1 other location - About 2 hrs to fix
              Application/Api/Education/Graduation/Evaluation/ApiEvaluation.php on lines 75..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status