Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Education/Prepare/Prepare.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function reorderDivision has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function reorderDivision($Reorder = null, $Additional = null)
    {

        if ($Additional
            && $Reorder
Severity: Minor
Found in Application/Api/Education/Prepare/Prepare.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reorderDivision has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function reorderDivision($Reorder = null, $Additional = null)
    {

        if ($Additional
            && $Reorder
Severity: Minor
Found in Application/Api/Education/Prepare/Prepare.php - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if ($Additional
            && $Reorder
            && isset($Additional['PrepareId'])
            && isset($Additional['PersonId'])
            && ($tblPrepare = \SPHERE\Application\Education\Certificate\Prepare\Prepare::useService()->getPrepareById($Additional['PrepareId']))
    Severity: Major
    Found in Application/Api/Education/Prepare/Prepare.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status