Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/People/Meta/Transfer/StudentService.php

Summary

Maintainability
F
1 wk
Test Coverage

Function createTransferCourse has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function createTransferCourse(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblCourse = null
    ) {
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTransferCompany has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function createTransferCompany(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblCompany = null
    ) {
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTransferType has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function createTransferType(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblSchoolType = null
    ) {
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTransferEnrollmentType has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function createTransferEnrollmentType(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblStudentSchoolEnrollmentType = null
    ) {
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTransferDate has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function createTransferDate(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $transferDate = null
    ) {
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTransferStateCompany has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function createTransferStateCompany(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblStateCompany = null
    ) {
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File StudentService.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Api\People\Meta\Transfer;

use SPHERE\Application\Corporation\Company\Service\Entity\TblCompany;
Severity: Minor
Found in Application/Api/People/Meta/Transfer/StudentService.php - About 2 hrs to fix

    Method createTransferType has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createTransferType(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblSchoolType = null
    ) {
    Severity: Minor
    Found in Application/Api/People/Meta/Transfer/StudentService.php - About 1 hr to fix

      Method createTransferCompany has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createTransferCompany(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblCompany = null
    ) {
      Severity: Minor
      Found in Application/Api/People/Meta/Transfer/StudentService.php - About 1 hr to fix

        Method createTransferCourse has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createTransferCourse(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblCourse = null
    ) {
        Severity: Minor
        Found in Application/Api/People/Meta/Transfer/StudentService.php - About 1 hr to fix

          Method createTransferStateCompany has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createTransferStateCompany(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblStateCompany = null
    ) {
          Severity: Minor
          Found in Application/Api/People/Meta/Transfer/StudentService.php - About 1 hr to fix

            Method createTransferDate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createTransferDate(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $transferDate = null
    ) {
            Severity: Minor
            Found in Application/Api/People/Meta/Transfer/StudentService.php - About 1 hr to fix

              Method createTransferEnrollmentType has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function createTransferEnrollmentType(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblStudentSchoolEnrollmentType = null
    ) {
              Severity: Minor
              Found in Application/Api/People/Meta/Transfer/StudentService.php - About 1 hr to fix

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function createTransferCourse(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblCourse = null
    ) {
                Severity: Major
                Found in Application/Api/People/Meta/Transfer/StudentService.php and 4 other locations - About 1 day to fix
                Application/Api/People/Meta/Transfer/StudentService.php on lines 23..68
                Application/Api/People/Meta/Transfer/StudentService.php on lines 77..122
                Application/Api/People/Meta/Transfer/StudentService.php on lines 131..177
                Application/Api/People/Meta/Transfer/StudentService.php on lines 240..285

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 305.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function createTransferEnrollmentType(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblStudentSchoolEnrollmentType = null
    ) {
                Severity: Major
                Found in Application/Api/People/Meta/Transfer/StudentService.php and 4 other locations - About 1 day to fix
                Application/Api/People/Meta/Transfer/StudentService.php on lines 23..68
                Application/Api/People/Meta/Transfer/StudentService.php on lines 77..122
                Application/Api/People/Meta/Transfer/StudentService.php on lines 131..177
                Application/Api/People/Meta/Transfer/StudentService.php on lines 186..231

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 305.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function createTransferType(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblSchoolType = null
    ) {
                Severity: Major
                Found in Application/Api/People/Meta/Transfer/StudentService.php and 4 other locations - About 1 day to fix
                Application/Api/People/Meta/Transfer/StudentService.php on lines 23..68
                Application/Api/People/Meta/Transfer/StudentService.php on lines 77..122
                Application/Api/People/Meta/Transfer/StudentService.php on lines 186..231
                Application/Api/People/Meta/Transfer/StudentService.php on lines 240..285

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 305.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function createTransferStateCompany(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblStateCompany = null
    ) {
                Severity: Major
                Found in Application/Api/People/Meta/Transfer/StudentService.php and 4 other locations - About 1 day to fix
                Application/Api/People/Meta/Transfer/StudentService.php on lines 23..68
                Application/Api/People/Meta/Transfer/StudentService.php on lines 131..177
                Application/Api/People/Meta/Transfer/StudentService.php on lines 186..231
                Application/Api/People/Meta/Transfer/StudentService.php on lines 240..285

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 305.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function createTransferCompany(
        $PersonIdArray = array(),
        $StudentTransferTypeIdentifier,
        $tblCompany = null
    ) {
                Severity: Major
                Found in Application/Api/People/Meta/Transfer/StudentService.php and 4 other locations - About 1 day to fix
                Application/Api/People/Meta/Transfer/StudentService.php on lines 77..122
                Application/Api/People/Meta/Transfer/StudentService.php on lines 131..177
                Application/Api/People/Meta/Transfer/StudentService.php on lines 186..231
                Application/Api/People/Meta/Transfer/StudentService.php on lines 240..285

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 305.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status