Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Platform/Gatekeeper/ApiUserGroup.php

Summary

Maintainability
C
1 day
Test Coverage

File ApiUserGroup.php has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Api\Platform\Gatekeeper;

use SPHERE\Application\Api\ApiTrait;
use SPHERE\Application\Api\Dispatcher;
Severity: Minor
Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 2 hrs to fix

    Method pieceGroupList has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function pieceGroupList($receiverGroupList, $receiverModalCreate, $receiverModalEdit, $receiverModalDestroy)
    {

        $tblGroupAll = Account::useService()->getGroupAll(
            Consumer::useService()->getConsumerBySession()
    Severity: Major
    Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 2 hrs to fix

      Method pieceDestroyGroupConfirm has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function pieceDestroyGroupConfirm($Id, $receiverGroupList, $receiverModalCreate, $receiverModalEdit, $receiverModalDestroy)
    {
        $tblGroup = Account::useService()->getGroupById($Id);

        if ($tblGroup) {
      Severity: Minor
      Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 1 hr to fix

        Method pieceEditGroup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function pieceEditGroup($Id, $Group, $receiverGroupList, $receiverModalCreate, $receiverModalEdit, $receiverModalDestroy)
    {
        $tblGroup = Account::useService()->getGroupById( $Id );
        if( $tblGroup ) {
        Severity: Minor
        Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 1 hr to fix

          Method pieceEditGroup has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function pieceEditGroup($Id, $Group, $receiverGroupList, $receiverModalCreate, $receiverModalEdit, $receiverModalDestroy)
          Severity: Minor
          Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 45 mins to fix

            Method pieceDestroyGroupConfirm has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function pieceDestroyGroupConfirm($Id, $receiverGroupList, $receiverModalCreate, $receiverModalEdit, $receiverModalDestroy)
            Severity: Minor
            Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 35 mins to fix

              Method pieceCreateGroup has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function pieceCreateGroup($Group, $receiverGroupList, $receiverModalCreate, $receiverModalEdit, $receiverModalDestroy)
              Severity: Minor
              Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function exportApi($MethodName = '')
    {
        $Dispatcher = new Dispatcher(__CLASS__);

        $Dispatcher->registerMethod('pieceGroupList');
                Severity: Major
                Found in Application/Api/Platform/Gatekeeper/ApiUserGroup.php and 1 other location - About 1 hr to fix
                Application/Api/Contact/ApiRelationshipToPerson.php on lines 64..84

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status