Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Api/Platform/Test/ApiSystemTest.php

Summary

Maintainability
C
1 day
Test Coverage

File ApiSystemTest.php has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Api\Platform\Test;

use SPHERE\Application\Api\ApiTrait;
Severity: Minor
Found in Application/Api/Platform/Test/ApiSystemTest.php - About 3 hrs to fix

    ApiSystemTest has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ApiSystemTest extends Extension implements IApiInterface
{

    use ApiTrait;
    Severity: Minor
    Found in Application/Api/Platform/Test/ApiSystemTest.php - About 3 hrs to fix

      Method openFirstModal has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function openFirstModal()
    {

        return new Layout(
            new LayoutGroup(array(
      Severity: Minor
      Found in Application/Api/Platform/Test/ApiSystemTest.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function openThirdModal()
    {

        return new Layout(
            new LayoutGroup(
        Severity: Major
        Found in Application/Api/Platform/Test/ApiSystemTest.php and 1 other location - About 1 hr to fix
        Application/Api/Setting/UserAccount/ApiUserAccount.php on lines 474..490

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status