DerDu/SPHERE-Framework

View on GitHub
Application/Api/Reporting/Custom/Chemnitz/Common.php

Summary

Maintainability
F
4 days
Test Coverage

Function downloadClubMemberList has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadClubMemberList()
    {

        $PersonList = Person::useService()->createClubMemberList();

Severity: Minor
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloadClassList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadClassList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Minor
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloadMedicList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadMedicList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Minor
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloadParentTeacherConferenceList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadParentTeacherConferenceList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Minor
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloadPrintClassList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadPrintClassList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Minor
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function downloadSchoolFeeList()
    {

        $PersonList = Person::useService()->createSchoolFeeList();
        if ($PersonList) {
Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 2 other locations - About 5 hrs to fix
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 49..71
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 158..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 195.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function downloadInterestedPersonList()
    {

        $PersonList = Person::useService()->createInterestedPersonList();
        if ($PersonList) {
Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 2 other locations - About 5 hrs to fix
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 49..71
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 184..205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 195.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function downloadStaffList()
    {

        $PersonList = Person::useService()->createStaffList();

Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 2 other locations - About 5 hrs to fix
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 158..179
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 184..205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 195.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function downloadPrintClassList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 1 other location - About 3 hrs to fix
Application/Api/Reporting/Standard/Person/Person.php on lines 125..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    public function downloadParentTeacherConferenceList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 16 other locations - About 3 hrs to fix
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 23..44
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 78..97
Application/Api/Reporting/Custom/Coswig/Common.php on lines 21..39
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 21..40
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 47..66
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 73..92
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 99..118
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 125..144
Application/Api/Reporting/Custom/Hormersdorf/Person.php on lines 22..41
Application/Api/Reporting/Custom/Radebeul/Person.php on lines 29..49
Application/Api/Reporting/Standard/Person/Person.php on lines 22..41
Application/Api/Reporting/Standard/Person/Person.php on lines 48..66
Application/Api/Reporting/Standard/Person/Person.php on lines 73..92
Application/Api/Reporting/Standard/Person/Person.php on lines 99..118
Application/Api/Reporting/Standard/Person/Person.php on lines 221..239
Application/Api/Reporting/Standard/Person/Person.php on lines 246..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    public function downloadMedicList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 16 other locations - About 3 hrs to fix
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 23..44
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 104..123
Application/Api/Reporting/Custom/Coswig/Common.php on lines 21..39
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 21..40
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 47..66
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 73..92
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 99..118
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 125..144
Application/Api/Reporting/Custom/Hormersdorf/Person.php on lines 22..41
Application/Api/Reporting/Custom/Radebeul/Person.php on lines 29..49
Application/Api/Reporting/Standard/Person/Person.php on lines 22..41
Application/Api/Reporting/Standard/Person/Person.php on lines 48..66
Application/Api/Reporting/Standard/Person/Person.php on lines 73..92
Application/Api/Reporting/Standard/Person/Person.php on lines 99..118
Application/Api/Reporting/Standard/Person/Person.php on lines 221..239
Application/Api/Reporting/Standard/Person/Person.php on lines 246..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    public function downloadClassList($DivisionId = null)
    {

        $tblDivision = Division::useService()->getDivisionById($DivisionId);
        if ($tblDivision) {
Severity: Major
Found in Application/Api/Reporting/Custom/Chemnitz/Common.php and 16 other locations - About 3 hrs to fix
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 78..97
Application/Api/Reporting/Custom/Chemnitz/Common.php on lines 104..123
Application/Api/Reporting/Custom/Coswig/Common.php on lines 21..39
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 21..40
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 47..66
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 73..92
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 99..118
Application/Api/Reporting/Custom/Herrnhut/Common.php on lines 125..144
Application/Api/Reporting/Custom/Hormersdorf/Person.php on lines 22..41
Application/Api/Reporting/Custom/Radebeul/Person.php on lines 29..49
Application/Api/Reporting/Standard/Person/Person.php on lines 22..41
Application/Api/Reporting/Standard/Person/Person.php on lines 48..66
Application/Api/Reporting/Standard/Person/Person.php on lines 73..92
Application/Api/Reporting/Standard/Person/Person.php on lines 99..118
Application/Api/Reporting/Standard/Person/Person.php on lines 221..239
Application/Api/Reporting/Standard/Person/Person.php on lines 246..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status