Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Accounting/Account/Service/Data.php

Summary

Maintainability
C
1 day
Test Coverage

Method createKey has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function createKey($ValidFrom, $Value, $ValidTo, $Description, $Code, TblAccountKeyType $tblAccountKeyType)
Severity: Minor
Found in Application/Billing/Accounting/Account/Service/Data.php - About 45 mins to fix

    Method updateAccount has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            TblAccount $tblAccount,
        $Description,
        $Number,
        $IsActive,
        TblAccountKey $tblAccountKey,
    Severity: Minor
    Found in Application/Billing/Accounting/Account/Service/Data.php - About 45 mins to fix

      Method createAccount has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function createAccount($Number, $Description, $isActive, TblAccountKey $Key, TblAccountType $Type)
      Severity: Minor
      Found in Application/Billing/Accounting/Account/Service/Data.php - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function createKeyType($Name, $Description)
    {

        $Manager = $this->getConnection()->getEntityManager();
        $Entity = $Manager->getEntity('TblAccountKeyType')->findOneBy(array(
        Severity: Major
        Found in Application/Billing/Accounting/Account/Service/Data.php and 1 other location - About 2 hrs to fix
        Application/Billing/Accounting/Account/Service/Data.php on lines 233..250

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function createType($Name, $Description)
    {

        $Manager = $this->getConnection()->getEntityManager();
        $Entity = $Manager->getEntity('TblAccountType')->findOneBy(array(
        Severity: Major
        Found in Application/Billing/Accounting/Account/Service/Data.php and 1 other location - About 2 hrs to fix
        Application/Billing/Accounting/Account/Service/Data.php on lines 139..156

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function updateActivateAccount(TblAccount $tblAccount)
    {

        $Manager = $this->getConnection()->getEntityManager();
        Severity: Major
        Found in Application/Billing/Accounting/Account/Service/Data.php and 1 other location - About 1 hr to fix
        Application/Billing/Accounting/Account/Service/Data.php on lines 322..340

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function updateDeactivateAccount(TblAccount $tblAccount)
    {

        $Manager = $this->getConnection()->getEntityManager();
        Severity: Major
        Found in Application/Billing/Accounting/Account/Service/Data.php and 1 other location - About 1 hr to fix
        Application/Billing/Accounting/Account/Service/Data.php on lines 297..315

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            public function createAccount($Number, $Description, $isActive, TblAccountKey $Key, TblAccountType $Type)
    {

        $Manager = $this->getConnection()->getEntityManager();
        Severity: Major
        Found in Application/Billing/Accounting/Account/Service/Data.php and 4 other locations - About 1 hr to fix
        Application/People/Meta/Student/Service/Data.php on lines 376..396
        Application/People/Meta/Student/Service/Data/Support.php on lines 166..185
        Application/Reporting/Individual/Service/Data.php on lines 249..261
        Application/Reporting/Individual/Service/Data.php on lines 272..284

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status