Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Accounting/Causer/Frontend.php

Summary

Maintainability
F
5 days
Test Coverage

Function getItemContent has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function getItemContent($PersonId = '', $ItemId = '', $IsOpen = false)
    {

        $PanelContent = array();
        $Accordion = '';
Severity: Minor
Found in Application/Billing/Accounting/Causer/Frontend.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Frontend.php has 466 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Billing\Accounting\Causer;

use SPHERE\Application\Api\Billing\Accounting\ApiBankReference;
use SPHERE\Application\Api\Billing\Accounting\ApiCauser;
Severity: Minor
Found in Application/Billing/Accounting/Causer/Frontend.php - About 7 hrs to fix

    Method getCauserTable has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getCauserTable($GroupId)
    {

        $TableContent = array();
        if(($tblGroup = Group::useService()->getGroupById($GroupId))){
    Severity: Major
    Found in Application/Billing/Accounting/Causer/Frontend.php - About 3 hrs to fix

      Method getItemContent has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getItemContent($PersonId = '', $ItemId = '', $IsOpen = false)
    {

        $PanelContent = array();
        $Accordion = '';
      Severity: Major
      Found in Application/Billing/Accounting/Causer/Frontend.php - About 3 hrs to fix

        Method getHistoryByPerson has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getHistoryByPerson($PersonId = '')
    {

        if(!$tblPerson = Person::useService()->getPersonById($PersonId)){
            return new Warning('Person nicht gefunden');
        Severity: Major
        Found in Application/Billing/Accounting/Causer/Frontend.php - About 2 hrs to fix

          Function getHistoryByPerson has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getHistoryByPerson($PersonId = '')
    {

        if(!$tblPerson = Person::useService()->getPersonById($PersonId)){
            return new Warning('Person nicht gefunden');
          Severity: Minor
          Found in Application/Billing/Accounting/Causer/Frontend.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method frontendCauserEdit has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendCauserEdit($GroupId = '', $PersonId = '')
    {

        $Stage = new Stage('Beitragsverursacher', 'bearbeiten');
        $Stage->addButton(new Standard('Zurück', __NAMESPACE__.'/View', new ChevronLeft(),
          Severity: Major
          Found in Application/Billing/Accounting/Causer/Frontend.php - About 2 hrs to fix

            Method layoutPersonGroupList has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function layoutPersonGroupList()
    {

        $tblGroupList = array();
        if(($tblSettingGroupPersonList = Setting::useService()->getSettingGroupPersonAll())){
            Severity: Minor
            Found in Application/Billing/Accounting/Causer/Frontend.php - About 1 hr to fix

              Function getReferenceContent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getReferenceContent($PersonId = '')
    {

        $content = '';
        if(($tblPerson = Person::useService()->getPersonById($PersonId))){
              Severity: Minor
              Found in Application/Billing/Accounting/Causer/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function layoutPersonGroupList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function layoutPersonGroupList()
    {

        $tblGroupList = array();
        if(($tblSettingGroupPersonList = Setting::useService()->getSettingGroupPersonAll())){
              Severity: Minor
              Found in Application/Billing/Accounting/Causer/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getCauserTable has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getCauserTable($GroupId)
    {

        $TableContent = array();
        if(($tblGroup = Group::useService()->getGroupById($GroupId))){
              Severity: Minor
              Found in Application/Billing/Accounting/Causer/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                                  if(($tblItemCalculation = Item::useService()->getItemCalculationNowByItemVariant($tblItemVariant))){
                                        $ItemPriceString = $tblItemCalculation->getPriceString();
                                    }
              Severity: Major
              Found in Application/Billing/Accounting/Causer/Frontend.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                    if($IsDebtorNumberNeed && !($tblDebtorNumber = Debtor::useService()->getDebtorNumberByPerson($tblPersonDebtor))){
                                        $Debtor .= ' '.new DangerText(new ToolTip(new Info(),
                                                'Keine Debitoren-Nr. hinterlegt'));
                                    }
                Severity: Major
                Found in Application/Billing/Accounting/Causer/Frontend.php - About 45 mins to fix

                  Function frontendCauserEdit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function frontendCauserEdit($GroupId = '', $PersonId = '')
    {

        $Stage = new Stage('Beitragsverursacher', 'bearbeiten');
        $Stage->addButton(new Standard('Zurück', __NAMESPACE__.'/View', new ChevronLeft(),
                  Severity: Minor
                  Found in Application/Billing/Accounting/Causer/Frontend.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (!empty($tblGroupList)) {
            /** @var TblGroup $tblGroup */
            foreach ($tblGroupList as $Index => $tblGroup) {

                $countContent = new Muted(new Small(Group::useService()->countMemberByGroup($tblGroup) . '&nbsp;Mitglieder'));
                  Severity: Major
                  Found in Application/Billing/Accounting/Causer/Frontend.php and 1 other location - About 6 hrs to fix
                  Application/Billing/Accounting/Debtor/Frontend.php on lines 115..144

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 217.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status