Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Accounting/Debtor/Frontend.php

Summary

Maintainability
F
3 days
Test Coverage

File Frontend.php has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Billing\Accounting\Debtor;

use SPHERE\Application\Api\Billing\Accounting\ApiBankAccount;
Severity: Minor
Found in Application/Billing/Accounting/Debtor/Frontend.php - About 4 hrs to fix

    Method layoutPersonGroupList has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function layoutPersonGroupList($GroupId = '')
    {

        $tblGroupList = array();
    Severity: Major
    Found in Application/Billing/Accounting/Debtor/Frontend.php - About 3 hrs to fix

      Function layoutPersonGroupList has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function layoutPersonGroupList($GroupId = '')
    {

        $tblGroupList = array();
      Severity: Minor
      Found in Application/Billing/Accounting/Debtor/Frontend.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getDebtorNumberContent has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getDebtorNumberContent($PersonId = '')
    {

        if(($tblPerson = Person::useService()->getPersonById($PersonId))){
            $IsDebtorNumberNeed = false;
      Severity: Minor
      Found in Application/Billing/Accounting/Debtor/Frontend.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getDebtorTable has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getDebtorTable($GroupId)
    {

        $TableContent = array();
        if(($tblGroup = Group::useService()->getGroupById($GroupId))){
      Severity: Major
      Found in Application/Billing/Accounting/Debtor/Frontend.php - About 2 hrs to fix

        Method getBankAccountPanel has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getBankAccountPanel($PersonId = '')
    {

        $FirstColumn = 3;
        $SecondColumn = 9;
        Severity: Major
        Found in Application/Billing/Accounting/Debtor/Frontend.php - About 2 hrs to fix

          Method getDebtorNumberContent has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getDebtorNumberContent($PersonId = '')
    {

        if(($tblPerson = Person::useService()->getPersonById($PersonId))){
            $IsDebtorNumberNeed = false;
          Severity: Minor
          Found in Application/Billing/Accounting/Debtor/Frontend.php - About 1 hr to fix

            Function getDebtorTable has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getDebtorTable($GroupId)
    {

        $TableContent = array();
        if(($tblGroup = Group::useService()->getGroupById($GroupId))){
            Severity: Minor
            Found in Application/Billing/Accounting/Debtor/Frontend.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!empty($tblGroupList)) {
            /** @var TblGroup $tblGroup */
            foreach ($tblGroupList as $Index => $tblGroup) {

                $countContent = new Muted(new Small(Group::useService()->countMemberByGroup($tblGroup) . '&nbsp;Mitglieder'));
            Severity: Major
            Found in Application/Billing/Accounting/Debtor/Frontend.php and 1 other location - About 6 hrs to fix
            Application/Billing/Accounting/Causer/Frontend.php on lines 93..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 217.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $tblGroupCustomList[] = Debtor::useService()->directRoute(
            new Form(new FormGroup(new FormRow(array(
                new FormColumn(new SelectBox('GroupId', '', array('{{ Name }}' => $rightBoxList)), 10)
            ,
                new FormColumn(new PullRight(new StandardForm('', new GroupIcon())), 2)
            Severity: Major
            Found in Application/Billing/Accounting/Debtor/Frontend.php and 1 other location - About 1 hr to fix
            Application/Billing/Accounting/Debtor/Frontend.php on lines 146..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $tblGroupLockedList[] = Debtor::useService()->directRoute(
            new Form(new FormGroup(new FormRow(array(
                new FormColumn(new SelectBox('GroupId', '', array('{{ Name }}' => $leftBoxList)), 10)
            ,
                new FormColumn(new PullRight(new StandardForm('', new GroupIcon())), 2)
            Severity: Major
            Found in Application/Billing/Accounting/Debtor/Frontend.php and 1 other location - About 1 hr to fix
            Application/Billing/Accounting/Debtor/Frontend.php on lines 153..158

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status