Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Accounting/Debtor/Service.php

Summary

Maintainability
D
2 days
Test Coverage

Service has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

class Service extends AbstractService
{

    /**
     * @param bool $doSimulation
Severity: Minor
Found in Application/Billing/Accounting/Debtor/Service.php - About 5 hrs to fix

    File Service.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Billing\Accounting\Debtor;

use SPHERE\Application\Billing\Accounting\Debtor\Service\Data;
use SPHERE\Application\Billing\Accounting\Debtor\Service\Entity\TblBankAccount;
    Severity: Minor
    Found in Application/Billing/Accounting/Debtor/Service.php - About 2 hrs to fix

      Method createDebtorSelection has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function createDebtorSelection(TblPerson $tblPersonCauser, TblPerson $tblPerson,
        TblPaymentType $tblPaymentType, TblItem $tblItem, TblDebtorPeriodType $tblDebtorPeriodType, $FromDate, $ToDate = null,
        TblItemVariant $tblItemVariant = null, $Value = '0', TblBankAccount $tblBankAccount = null,
        TblBankReference $tblBankReference = null
      Severity: Major
      Found in Application/Billing/Accounting/Debtor/Service.php - About 1 hr to fix

        Method changeDebtorSelection has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function changeDebtorSelection(TblDebtorSelection $tblDebtorSelection, TblPerson $tblPerson,
        TblPaymentType $tblPaymentType, TblDebtorPeriodType $tblDebtorPeriodType, $FromDate, $ToDate = '',TblItemVariant $tblItemVariant = null,
        $Value = '0', TblBankAccount $tblBankAccount = null, TblBankReference $tblBankReference = null
        Severity: Major
        Found in Application/Billing/Accounting/Debtor/Service.php - About 1 hr to fix

          Function directRoute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function directRoute(IFormInterface &$Form, $GroupId = null, $Direction = '')
    {

        /**
         * Skip to Frontend
          Severity: Minor
          Found in Application/Billing/Accounting/Debtor/Service.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createBankAccount has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function createBankAccount(TblPerson $tblPerson, $Owner = '', $BankName = '', $IBAN = '', $BIC = '')
          Severity: Minor
          Found in Application/Billing/Accounting/Debtor/Service.php - About 35 mins to fix

            Method changeBankAccount has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function changeBankAccount(TblBankAccount $tblBankAccount, $Owner = '', $BankName = '', $IBAN = '', $BIC = ''
            Severity: Minor
            Found in Application/Billing/Accounting/Debtor/Service.php - About 35 mins to fix

              Function getDebtorMaxNumber has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getDebtorMaxNumber()
    {

        $result = 0;
        if(($tblDebtorNumberList = (new Data($this->getBinding()))->getDebtorNumberAll())) {
              Severity: Minor
              Found in Application/Billing/Accounting/Debtor/Service.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getBankReferenceMaxNumber has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getBankReferenceMaxNumber()
    {

        $result = 0;
        if(($tblBankReferenceList = (new Data($this->getBinding()))->getBankReferenceAll())) {
              Severity: Minor
              Found in Application/Billing/Accounting/Debtor/Service.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return $Form;
              Severity: Major
              Found in Application/Billing/Accounting/Debtor/Service.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createBankAccount(TblPerson $tblPerson, $Owner = '', $BankName = '', $IBAN = '', $BIC = '')
    {

        $IBAN = str_replace(' ', '', $IBAN);
        $BIC = str_replace(' ', '', $BIC);
                Severity: Major
                Found in Application/Billing/Accounting/Debtor/Service.php and 1 other location - About 1 hr to fix
                Application/Billing/Accounting/Debtor/Service.php on lines 465..472

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function changeBankAccount(TblBankAccount $tblBankAccount, $Owner = '', $BankName = '', $IBAN = '', $BIC = ''
    ){

        $IBAN = str_replace(' ', '', $IBAN);
        $BIC = str_replace(' ', '', $BIC);
                Severity: Major
                Found in Application/Billing/Accounting/Debtor/Service.php and 1 other location - About 1 hr to fix
                Application/Billing/Accounting/Debtor/Service.php on lines 383..390

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createDebtorNumber(TblPerson $tblPerson, $Number)
    {

        if($DebtorCountSetting = Setting::useService()->getSettingByIdentifier(TblSetting::IDENT_DEBTOR_NUMBER_COUNT)){
            $count = $DebtorCountSetting->getValue();
                Severity: Minor
                Found in Application/Billing/Accounting/Debtor/Service.php and 1 other location - About 50 mins to fix
                Application/Billing/Accounting/Debtor/Service.php on lines 443..454

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function changeDebtorNumber(TblDebtorNumber $tblDebtorNumber, $Number = '')
    {

        if($DebtorCountSetting = Setting::useService()->getSettingByIdentifier(TblSetting::IDENT_DEBTOR_NUMBER_COUNT)){
            $count = $DebtorCountSetting->getValue();
                Severity: Minor
                Found in Application/Billing/Accounting/Debtor/Service.php and 1 other location - About 50 mins to fix
                Application/Billing/Accounting/Debtor/Service.php on lines 361..372

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createDebtorSelection(TblPerson $tblPersonCauser, TblPerson $tblPerson,
        TblPaymentType $tblPaymentType, TblItem $tblItem, TblDebtorPeriodType $tblDebtorPeriodType, $FromDate, $ToDate = null,
        TblItemVariant $tblItemVariant = null, $Value = '0', TblBankAccount $tblBankAccount = null,
        TblBankReference $tblBankReference = null
    ){
                Severity: Minor
                Found in Application/Billing/Accounting/Debtor/Service.php and 1 other location - About 30 mins to fix
                Application/Billing/Accounting/Debtor/Service/Data.php on lines 470..514

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 91.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status