Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Bookkeeping/Balance/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

File Frontend.php has 729 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Billing\Bookkeeping\Balance;

use SPHERE\Application\Api\Billing\Inventory\ApiDocument;
Severity: Major
Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 1 day to fix

    Function frontendBalanceExcel has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendBalanceExcel($Balance = array())
    {

        $Stage = new Stage('Belegdruck', 'Serienbrief');
    Severity: Minor
    Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function frontendBalancePdf has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendBalancePdf($Balance = array())
    {

        $Stage = new Stage('Belegdruck', 'PDF');
        if(!isset($Balance['Year'])){
    Severity: Minor
    Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getFilterForm has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getFilterForm($Balance, IMessageInterface $message = null, $IsMultiItem = '0')
    {

        $filterOptions = array(
            self::FILTER_CLASS => 'Klasse',
    Severity: Minor
    Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method frontendBalanceExcel has 153 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendBalanceExcel($Balance = array())
    {

        $Stage = new Stage('Belegdruck', 'Serienbrief');
    Severity: Major
    Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 6 hrs to fix

      Method getPdfForm has 145 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPdfForm(TblItem $tblItem, $tblDocumentList, $countPdfs, $Balance = null, $Data = null)
    {

        $Location = '';
        $Date = '';
      Severity: Major
      Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 5 hrs to fix

        Method getFilterForm has 135 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getFilterForm($Balance, IMessageInterface $message = null, $IsMultiItem = '0')
    {

        $filterOptions = array(
            self::FILTER_CLASS => 'Klasse',
        Severity: Major
        Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 5 hrs to fix

          Method frontendBalancePdf has 121 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendBalancePdf($Balance = array())
    {

        $Stage = new Stage('Belegdruck', 'PDF');
        if(!isset($Balance['Year'])){
          Severity: Major
          Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 4 hrs to fix

            Function getPdfForm has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getPdfForm(TblItem $tblItem, $tblDocumentList, $countPdfs, $Balance = null, $Data = null)
    {

        $Location = '';
        $Date = '';
            Severity: Minor
            Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getDocumentPanel has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getDocumentPanel(TblItem $tblItem, $Data, $Location, $Date)
    {
        $global = $this->getGlobal();
        $tblDocumentList = Document::useService()->getDocumentAllByItem($tblItem);
        if (!($tblDocument = Document::useService()->getDocumentById($Data['Document']))) {
            Severity: Minor
            Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 1 hr to fix

              Method loadPersonSearch has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function loadPersonSearch($Search, IMessageInterface $message = null)
    {

        if ($Search != '' && strlen($Search) > 2) {
            if (($tblPersonList = Person::useService()->getPersonListLike($Search))) {
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 1 hr to fix

                Function loadPersonSearch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function loadPersonSearch($Search, IMessageInterface $message = null)
    {

        if ($Search != '' && strlen($Search) > 2) {
            if (($tblPersonList = Person::useService()->getPersonListLike($Search))) {
                Severity: Minor
                Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getDocumentPanel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getDocumentPanel(TblItem $tblItem, $Data, $Location, $Date)
    {
        $global = $this->getGlobal();
        $tblDocumentList = Document::useService()->getDocumentAllByItem($tblItem);
        if (!($tblDocument = Document::useService()->getDocumentById($Data['Document']))) {
                Severity: Minor
                Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getPdfForm has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getPdfForm(TblItem $tblItem, $tblDocumentList, $countPdfs, $Balance = null, $Data = null)
                Severity: Minor
                Found in Application/Billing/Bookkeeping/Balance/Frontend.php - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  $result = new TableData(
                    $resultList,
                    null,
                    array(
                        'Select' => '',
                  Severity: Major
                  Found in Application/Billing/Bookkeeping/Balance/Frontend.php and 1 other location - About 1 hr to fix
                  Application/People/Relationship/Frontend.php on lines 347..366

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status