Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Bookkeeping/Basket/Frontend.php

Summary

Maintainability
F
4 days
Test Coverage

File Frontend.php has 542 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Billing\Bookkeeping\Basket;

use SPHERE\Application\Api\Billing\Bookkeeping\ApiBasket;
Severity: Major
Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 1 day to fix

    Method getBasketVerificationLayout has 214 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getBasketVerificationLayout($BasketId = null)
    {

        $tblBasket = Basket::useService()->getBasketById($BasketId);
        if(!$tblBasket){
    Severity: Major
    Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 1 day to fix

      Function getBasketVerificationLayout has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getBasketVerificationLayout($BasketId = null)
    {

        $tblBasket = Basket::useService()->getBasketById($BasketId);
        if(!$tblBasket){
      Severity: Minor
      Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getBasketTable has 97 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getBasketTable($IsArchive = false)
    {

        // kommt manchmal als string
        if($IsArchive == 'false' || $IsArchive === false){
      Severity: Major
      Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 3 hrs to fix

        Function getDownloadButtons has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getDownloadButtons(TblBasket $tblBasket)
    {

        $Buttons = '';
        $IsSepa = false;
        Severity: Minor
        Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method frontendBasketList has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendBasketList($IsArchive = false)
    {

        if($IsArchive){
            $Stage = new Stage('Archiv', 'Abrechnung');
        Severity: Minor
        Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 1 hr to fix

          Method getDownloadButtons has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getDownloadButtons(TblBasket $tblBasket)
    {

        $Buttons = '';
        $IsSepa = false;
          Severity: Minor
          Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 1 hr to fix

            Method frontendBasketView has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendBasketView($BasketId = null)
    {

        // out of memory (Test with 3300 entrys)
        ini_set('memory_limit', '-1');
            Severity: Minor
            Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if($IsDatev){
                if ($tblBasket->getDatevDate()){
                    $Buttons .= (new Standard('DATEV', '\Api\Billing\Datev\Download', new Download(),
                        array('BasketId' => $tblBasket->getId()), 'DATEV Download'));
                } else {
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Basket/Frontend.php and 1 other location - About 40 mins to fix
              Application/Billing/Bookkeeping/Basket/Frontend.php on lines 262..270

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 94.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if($IsSepa){
                if($tblBasket->getDatevDate()){
                    $Buttons .= (new Standard('SEPA', '\Api\Billing\Sepa\Credit\Download', new Download(),
                        array('BasketId' => $tblBasket->getId()), 'SEPA Download'));
                } else {
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Basket/Frontend.php and 1 other location - About 40 mins to fix
              Application/Billing/Bookkeeping/Basket/Frontend.php on lines 290..298

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 94.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status