Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Bookkeeping/Basket/Service.php

Summary

Maintainability
F
6 days
Test Coverage

Function createBasketVerificationBulk has a Cognitive Complexity of 120 (exceeds 5 allowed). Consider refactoring.
Open

    public function createBasketVerificationBulk(TblBasket $tblBasket, TblItem $tblItem, TblDivision $tblDivision = null, TblType $tblType = null)
    {

        $tblGroupList = $this->getGroupListByItem($tblItem);
Severity: Minor
Found in Application/Billing/Bookkeeping/Basket/Service.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Service.php has 454 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Billing\Bookkeeping\Basket;

use SPHERE\Application\Billing\Accounting\Creditor\Creditor;
Severity: Minor
Found in Application/Billing/Bookkeeping/Basket/Service.php - About 6 hrs to fix

    Method createBasketVerificationBulk has 135 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createBasketVerificationBulk(TblBasket $tblBasket, TblItem $tblItem, TblDivision $tblDivision = null, TblType $tblType = null)
    {

        $tblGroupList = $this->getGroupListByItem($tblItem);
    Severity: Major
    Found in Application/Billing/Bookkeeping/Basket/Service.php - About 5 hrs to fix

      Service has 36 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Service extends AbstractService
{

    /**
     * @param bool $doSimulation
      Severity: Minor
      Found in Application/Billing/Bookkeeping/Basket/Service.php - About 4 hrs to fix

        Function filterPersonListBySchoolType has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            private function filterPersonListBySchoolType($tblPersonList, TblType $tblType)
    {

        $resultPersonList = array();
        if(!empty($tblPersonList)){
        Severity: Minor
        Found in Application/Billing/Bookkeeping/Basket/Service.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createBasket has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function createBasket($Name = '', $Description = '', $Year = '', $Month = '', $TargetTime = '', $BillTime = '',
        TblBasketType $tblBasketType = null, $CreditorId = '', TblDivision $tblDivision = null, TblType $tblType = null,
        TblDebtorPeriodType $tblDebtorPeriodType = null)
        Severity: Major
        Found in Application/Billing/Bookkeeping/Basket/Service.php - About 1 hr to fix

          Function getPersonListByGroupList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getPersonListByGroupList($tblGroupList)
    {

        $tblPersonList = array();
        if($tblGroupList){
          Severity: Minor
          Found in Application/Billing/Bookkeeping/Basket/Service.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method changeBasketVerificationDebtor has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  TblBasketVerification $tblBasketVerification,
        TblPerson $tblPersonDebtor,
        TblPaymentType $tblPaymentType,
        $Value = '0',
        TblItemVariant $tblItemVariant = null,
          Severity: Major
          Found in Application/Billing/Bookkeeping/Basket/Service.php - About 50 mins to fix

            Function getActiveBasketVerificationByDebtorSelection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getActiveBasketVerificationByDebtorSelection(TblDebtorSelection $tblDebtorSelection)
    {

        if(($tblBasketVerificationList = $this->getBasketVerificationAllByDebtorSelection($tblDebtorSelection))){
            $BasketVerificationList = array();
            Severity: Minor
            Found in Application/Billing/Bookkeeping/Basket/Service.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method changeBasket has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function changeBasket(TblBasket $tblBasket, $Name, $Description, $TargetTime, $BillTime, $CreditorId = '')
            Severity: Minor
            Found in Application/Billing/Bookkeeping/Basket/Service.php - About 45 mins to fix

              Function getItemAllByBasket has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getItemAllByBasket(TblBasket $tblBasket)
    {

        $tblBasketItemList = $this->getBasketItemAllByBasket($tblBasket);
        $tblItemList = array();
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Basket/Service.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function createBasket has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function createBasket($Name = '', $Description = '', $Year = '', $Month = '', $TargetTime = '', $BillTime = '',
        TblBasketType $tblBasketType = null, $CreditorId = '', TblDivision $tblDivision = null, TblType $tblType = null,
        TblDebtorPeriodType $tblDebtorPeriodType = null)
    {
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Basket/Service.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function filterPersonListByDivision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function filterPersonListByDivision($tblPersonList, TblDivision $tblDivision)
    {

        $resultPersonList = array();
        if(!empty($tblPersonList)){
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Basket/Service.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function changeBasketDoneDatev(TblBasket $tblBasket)
    {

        $PersonName = 'Person nicht hinterlegt!';
        if(($tblAccount = Account::useService()->getAccountBySession())){
              Severity: Major
              Found in Application/Billing/Bookkeeping/Basket/Service.php and 1 other location - About 2 hrs to fix
              Application/Billing/Bookkeeping/Basket/Service.php on lines 634..647

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function changeBasketDoneSepa(TblBasket $tblBasket)
    {

        $PersonName = 'Person nicht hinterlegt!';
        if(($tblAccount = Account::useService()->getAccountBySession())){
              Severity: Major
              Found in Application/Billing/Bookkeeping/Basket/Service.php and 1 other location - About 2 hrs to fix
              Application/Billing/Bookkeeping/Basket/Service.php on lines 654..667

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status