Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Bookkeeping/Invoice/Service/Data.php

Summary

Maintainability
D
1 day
Test Coverage

File Data.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Billing\Bookkeeping\Invoice\Service;

use SPHERE\Application\Billing\Accounting\Creditor\Service\Entity\TblCreditor;
Severity: Minor
Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 3 hrs to fix

    Method createInvoiceItemDebtorList has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createInvoiceItemDebtorList($InvoiceCauserList)
    {

        if(!empty($InvoiceCauserList)){
            $Manager = $this->getConnection()->getEntityManager();
    Severity: Major
    Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 2 hrs to fix

      Method createInvoiceList has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createInvoiceList($InvoiceList, $Month, $Year, $TargetTime, $BillTime, TblBasket $tblBasket)
    {
        //ToDO $InvoiceNumberLength from Setting?
        $InvoiceNumberLength = 5;
        if(!empty($InvoiceList)){
      Severity: Minor
      Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 1 hr to fix

        Method createInvoiceCreditorList has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createInvoiceCreditorList($InvoiceCreditor = array())
    {

        $Manager = $this->getConnection()->getEntityManager();
        /** @var TblCreditor $tblCreditor */
        Severity: Minor
        Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 1 hr to fix

          Function createInvoiceItemDebtorList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createInvoiceItemDebtorList($InvoiceCauserList)
    {

        if(!empty($InvoiceCauserList)){
            $Manager = $this->getConnection()->getEntityManager();
          Severity: Minor
          Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createInvoice has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $IntegerNumber,
        $Month,
        $Year,
        $TargetTime,
        $BillTime,
          Severity: Major
          Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 1 hr to fix

            Method createInvoiceList has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function createInvoiceList($InvoiceList, $Month, $Year, $TargetTime, $BillTime, TblBasket $tblBasket)
            Severity: Minor
            Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 45 mins to fix

              Function createInvoiceList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function createInvoiceList($InvoiceList, $Month, $Year, $TargetTime, $BillTime, TblBasket $tblBasket)
    {
        //ToDO $InvoiceNumberLength from Setting?
        $InvoiceNumberLength = 5;
        if(!empty($InvoiceList)){
              Severity: Minor
              Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                  public function changeInvoiceItemDebtorIsPaid(TblInvoiceItemDebtor $tblInvoiceItemDebtor, $isPaid = true)
    {
        $Manager = $this->getConnection()->getEntityManager();

        /** @var TblInvoiceItemDebtor $Entity */
              Severity: Major
              Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php and 5 other locations - About 2 hrs to fix
              Application/Education/Certificate/Generate/Service/Data.php on lines 167..187
              Application/People/Relationship/Service/Data.php on lines 216..229
              Application/Transfer/Indiware/Import/Service/Data.php on lines 495..513
              Application/Transfer/Indiware/Import/Service/Data.php on lines 541..559
              Application/Transfer/Untis/Import/Service/Data.php on lines 145..161

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 128.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      if($Entity === null){
            $Entity = new TblInvoiceCreditor();
            $Entity->setCreditorId($CreditorId);
            $Entity->setOwner($Owner);
            $Entity->setBankName($BankName);
              Severity: Major
              Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php and 3 other locations - About 50 mins to fix
              Application/Document/Storage/Service/Data.php on lines 381..391
              Application/Education/Certificate/Prepare/Service/Data.php on lines 470..487
              Application/People/Meta/Student/Service/Data/Subject.php on lines 208..230

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status