Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Inventory/Document/Frontend.php

Summary

Maintainability
D
2 days
Test Coverage

Function formDocument has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function formDocument($DocumentId = null, $setPost = false)
    {
        if ($DocumentId && ($tblDocument = Document::useService()->getDocumentById($DocumentId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
Severity: Minor
Found in Application/Billing/Inventory/Document/Frontend.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Frontend.php has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 11.03.2019
Severity: Minor
Found in Application/Billing/Inventory/Document/Frontend.php - About 2 hrs to fix

    Method loadDocumentOverviewContent has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadDocumentOverviewContent()
    {
        if (($tblDocumentList = Document::useService()->getDocumentAll())) {
            $contentTable = array();
            foreach ($tblDocumentList as $tblDocument) {
    Severity: Major
    Found in Application/Billing/Inventory/Document/Frontend.php - About 2 hrs to fix

      Function loadDocumentOverviewContent has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function loadDocumentOverviewContent()
    {
        if (($tblDocumentList = Document::useService()->getDocumentAll())) {
            $contentTable = array();
            foreach ($tblDocumentList as $tblDocument) {
      Severity: Minor
      Found in Application/Billing/Inventory/Document/Frontend.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method formDocument has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function formDocument($DocumentId = null, $setPost = false)
    {
        if ($DocumentId && ($tblDocument = Document::useService()->getDocumentById($DocumentId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
      Severity: Major
      Found in Application/Billing/Inventory/Document/Frontend.php - About 2 hrs to fix

        Method frontendEditDocumentInformation has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendEditDocumentInformation($DocumentId = null, $Data = null)
    {
        $Stage = new Stage('Belegdruck', 'Inhalt bearbeiten');
        $Stage->addButton(new Standard(
            'Zurück', '/Billing/Inventory/Document', new ChevronLeft()
        Severity: Minor
        Found in Application/Billing/Inventory/Document/Frontend.php - About 1 hr to fix

          Method getFreeFields has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getFreeFields($IsWarning = false)
    {

        if($IsWarning){
            return array(
          Severity: Minor
          Found in Application/Billing/Inventory/Document/Frontend.php - About 1 hr to fix

            Function frontendEditDocumentInformation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frontendEditDocumentInformation($DocumentId = null, $Data = null)
    {
        $Stage = new Stage('Belegdruck', 'Inhalt bearbeiten');
        $Stage->addButton(new Standard(
            'Zurück', '/Billing/Inventory/Document', new ChevronLeft()
            Severity: Minor
            Found in Application/Billing/Inventory/Document/Frontend.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status