Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Billing/Inventory/Setting/Frontend.php

Summary

Maintainability
F
5 days
Test Coverage

File Frontend.php has 493 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Billing\Inventory\Setting;

use SPHERE\Application\Api\Billing\Inventory\ApiSetting;
use SPHERE\Application\Billing\Inventory\Setting\Service\Entity\TblSetting;
Severity: Minor
Found in Application/Billing/Inventory/Setting/Frontend.php - About 7 hrs to fix

    Method formSetting has 155 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formSetting($Category = TblSetting::CATEGORY_REGULAR)
    {

        $elementList = array();
        $tblSettingList = Setting::useService()->getSettingAllByCategory($Category);
    Severity: Major
    Found in Application/Billing/Inventory/Setting/Frontend.php - About 6 hrs to fix

      Method displaySetting has 126 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function displaySetting($Category = TblSetting::CATEGORY_REGULAR)
    {

        $tblSettingList = Setting::useService()->getSettingAllByCategory($Category);
        $Listing = array();
      Severity: Major
      Found in Application/Billing/Inventory/Setting/Frontend.php - About 5 hrs to fix

        Function displaySetting has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function displaySetting($Category = TblSetting::CATEGORY_REGULAR)
    {

        $tblSettingList = Setting::useService()->getSettingAllByCategory($Category);
        $Listing = array();
        Severity: Minor
        Found in Application/Billing/Inventory/Setting/Frontend.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function formSetting has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            public function formSetting($Category = TblSetting::CATEGORY_REGULAR)
    {

        $elementList = array();
        $tblSettingList = Setting::useService()->getSettingAllByCategory($Category);
        Severity: Minor
        Found in Application/Billing/Inventory/Setting/Frontend.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method displayPersonGroup has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function displayPersonGroup()
    {
        if(($tblSettingGroupPersonList = Setting::useService()->getSettingGroupPersonAll())){
            $tblGroupList = array();
            foreach($tblSettingGroupPersonList as $tblSettingGroupPerson) {
        Severity: Major
        Found in Application/Billing/Inventory/Setting/Frontend.php - About 2 hrs to fix

          Method formPersonGroup has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function formPersonGroup()
    {
        if(($tblSettingGroupList = Setting::useService()->getSettingGroupPersonAll())){
            $Global = $this->getGlobal();
            foreach($tblSettingGroupList as $tblSettingGroup) {
          Severity: Minor
          Found in Application/Billing/Inventory/Setting/Frontend.php - About 1 hr to fix

            Function displayPersonGroup has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public function displayPersonGroup()
    {
        if(($tblSettingGroupPersonList = Setting::useService()->getSettingGroupPersonAll())){
            $tblGroupList = array();
            foreach($tblSettingGroupPersonList as $tblSettingGroupPerson) {
            Severity: Minor
            Found in Application/Billing/Inventory/Setting/Frontend.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function formPersonGroup has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function formPersonGroup()
    {
        if(($tblSettingGroupList = Setting::useService()->getSettingGroupPersonAll())){
            $Global = $this->getGlobal();
            foreach($tblSettingGroupList as $tblSettingGroup) {
            Severity: Minor
            Found in Application/Billing/Inventory/Setting/Frontend.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        new LayoutColumn(new Panel('SEPA-Verwendungszweck', array(
                                new TextField('Setting['.TblSetting::IDENT_SEPA_REMARK.']', '', ''),
                                new Layout(new LayoutGroup(new LayoutRow(array(
                                    new LayoutColumn(new Bold('Freifelder für Verwendungszweck')),
                                    new LayoutColumn('[GID] Gläubiger-ID', 4),
            Severity: Major
            Found in Application/Billing/Inventory/Setting/Frontend.php and 1 other location - About 3 hrs to fix
            Application/Billing/Inventory/Setting/Frontend.php on lines 458..469

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 151.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        new LayoutColumn(new Panel('DATEV-Buchungstext '.new ToolTip(new Info(), 'Datev erlaubt maximal 60 Zeichen, der rest wird abgeschnitten'), array(
                                new TextField('Setting['.TblSetting::IDENT_DATEV_REMARK.']', '', ''),
                                new Layout(new LayoutGroup(new LayoutRow(array(
                                    new LayoutColumn(new Bold('Freifelder für Buchungstext')),
                                    new LayoutColumn('[GID] Gläubiger-ID', 4),
            Severity: Major
            Found in Application/Billing/Inventory/Setting/Frontend.php and 1 other location - About 3 hrs to fix
            Application/Billing/Inventory/Setting/Frontend.php on lines 396..407

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 151.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case TblSetting::IDENT_IS_SEPA:
                    // Sepa ElementGroup
                    $SepaElementInWell = new WellReadOnly(
                        new Layout(new LayoutGroup(new LayoutRow(array(
                            new LayoutColumn(
            Severity: Major
            Found in Application/Billing/Inventory/Setting/Frontend.php and 1 other location - About 2 hrs to fix
            Application/Billing/Inventory/Setting/Frontend.php on lines 416..430

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 126.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case TblSetting::IDENT_IS_DATEV:
                    // Datev ElementGroup
                    $DatevElementInWell = new WellReadOnly(
                        new Layout(new LayoutGroup(new LayoutRow(array(
                            new LayoutColumn(
            Severity: Major
            Found in Application/Billing/Inventory/Setting/Frontend.php and 1 other location - About 2 hrs to fix
            Application/Billing/Inventory/Setting/Frontend.php on lines 371..387

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 126.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case TblSetting::IDENT_FIBU_TO_ACCOUNT:
                    $_POST['Setting'][TblSetting::IDENT_FIBU_TO_ACCOUNT] = $tblSetting->getValue();
                    $elementList[8] = new TextField('Setting['.TblSetting::IDENT_FIBU_TO_ACCOUNT.']', '', 'Fibu-Gegenkonto '
                        .new ToolTip(new Info(), 'Diese Vorgabe wird für alle Beitragsarten als Standardwert verwendet.
                                 Individuelle Einstellungen können an der Beitragsart vorgenommen werden.')
            Severity: Minor
            Found in Application/Billing/Inventory/Setting/Frontend.php and 1 other location - About 30 mins to fix
            Application/Billing/Inventory/Setting/Frontend.php on lines 472..478

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case TblSetting::IDENT_FIBU_ACCOUNT:
                    $_POST['Setting'][TblSetting::IDENT_FIBU_ACCOUNT] = $tblSetting->getValue();
                    $elementList[7] = new TextField('Setting['.TblSetting::IDENT_FIBU_ACCOUNT.']', '', 'Fibu-Konto '
                        .new ToolTip(new Info(), 'Diese Vorgabe wird für alle Beitragsarten als Standardwert verwendet.
                                 Individuelle Einstellungen können an der Beitragsart vorgenommen werden.')
            Severity: Minor
            Found in Application/Billing/Inventory/Setting/Frontend.php and 1 other location - About 30 mins to fix
            Application/Billing/Inventory/Setting/Frontend.php on lines 479..485

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status