Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Contact/Phone/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

Function frontendLayoutPersonNew has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
Open

    public function frontendLayoutPersonNew(TblPerson $tblPerson)
    {

        $phoneList = array();
        $phoneEmergencyList = array();
Severity: Minor
Found in Application/Contact/Phone/Frontend.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method frontendLayoutPersonNew has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendLayoutPersonNew(TblPerson $tblPerson)
    {

        $phoneList = array();
        $phoneEmergencyList = array();
Severity: Major
Found in Application/Contact/Phone/Frontend.php - About 5 hrs to fix

    File Frontend.php has 338 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Contact\Phone;

use SPHERE\Application\Api\Contact\ApiPhoneToCompany;
use SPHERE\Application\Api\Contact\ApiPhoneToPerson;
    Severity: Minor
    Found in Application/Contact/Phone/Frontend.php - About 4 hrs to fix

      Method frontendLayoutCompanyNew has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendLayoutCompanyNew(TblCompany $tblCompany)
    {

        if (($tblPhoneList = Phone::useService()->getPhoneAllByCompany($tblCompany))){
            $LayoutRowList = array();
      Severity: Major
      Found in Application/Contact/Phone/Frontend.php - About 2 hrs to fix

        Function frontendLayoutCompanyNew has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function frontendLayoutCompanyNew(TblCompany $tblCompany)
    {

        if (($tblPhoneList = Phone::useService()->getPhoneAllByCompany($tblCompany))){
            $LayoutRowList = array();
        Severity: Minor
        Found in Application/Contact/Phone/Frontend.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method formNumberToPerson has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function formNumberToPerson($PersonId, $ToPersonId = null, $setPost = false)
    {
        if ($ToPersonId && ($tblToPerson = Phone::useService()->getPhoneToPersonById($ToPersonId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
        Severity: Minor
        Found in Application/Contact/Phone/Frontend.php - About 1 hr to fix

          Method formNumberToCompany has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function formNumberToCompany($CompanyId, $ToCompanyId = null, $setPost = false)
    {
        if ($ToCompanyId && ($tblToCompany = Phone::useService()->getPhoneToCompanyById($ToCompanyId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
          Severity: Minor
          Found in Application/Contact/Phone/Frontend.php - About 1 hr to fix

            Function formNumberToPerson has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function formNumberToPerson($PersonId, $ToPersonId = null, $setPost = false)
    {
        if ($ToPersonId && ($tblToPerson = Phone::useService()->getPhoneToPersonById($ToPersonId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
            Severity: Minor
            Found in Application/Contact/Phone/Frontend.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function formNumberToCompany has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function formNumberToCompany($CompanyId, $ToCompanyId = null, $setPost = false)
    {
        if ($ToCompanyId && ($tblToCompany = Phone::useService()->getPhoneToCompanyById($ToCompanyId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
            Severity: Minor
            Found in Application/Contact/Phone/Frontend.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function formNumberToPerson($PersonId, $ToPersonId = null, $setPost = false)
    {
        if ($ToPersonId && ($tblToPerson = Phone::useService()->getPhoneToPersonById($ToPersonId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
            Severity: Major
            Found in Application/Contact/Phone/Frontend.php and 1 other location - About 2 days to fix
            Application/Contact/Phone/Frontend.php on lines 116..167

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 441.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function formNumberToCompany($CompanyId, $ToCompanyId = null, $setPost = false)
    {
        if ($ToCompanyId && ($tblToCompany = Phone::useService()->getPhoneToCompanyById($ToCompanyId))) {
            // beim Checken der Inputfeldern darf der Post nicht gesetzt werden
            if ($setPost) {
            Severity: Major
            Found in Application/Contact/Phone/Frontend.php and 1 other location - About 2 days to fix
            Application/Contact/Phone/Frontend.php on lines 56..107

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 441.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                        foreach ($personArray as $personId => $tblToPerson) {
                                if (($tblPersonPhone = Person::useService()->getPersonById($personId))) {
                                    $content[] = ($tblPerson->getId() != $tblPersonPhone->getId()
                                            ? new Link(
                                                new PersonIcon() . ' ' . $tblPersonPhone->getFullName(),
            Severity: Major
            Found in Application/Contact/Phone/Frontend.php and 2 other locations - About 2 hrs to fix
            Application/Contact/Address/Frontend.php on lines 383..397
            Application/Contact/Mail/Frontend.php on lines 246..260

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 136.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                $panel = FrontendReadOnly::getContactPanel(
                        (preg_match('!Fax!is',
                            $tblType->getName() . ' ' . $tblType->getDescription())
                            ? new PhoneFax()
                            : (preg_match('!Mobil!is',
            Severity: Major
            Found in Application/Contact/Phone/Frontend.php and 1 other location - About 1 hr to fix
            Application/Contact/Phone/Frontend.php on lines 289..303

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                        $panel = FrontendReadOnly::getContactPanel(
                                (preg_match('!Fax!is',
                                    $tblType->getName() . ' ' . $tblType->getDescription())
                                    ? new PhoneFax()
                                    : (preg_match('!Mobil!is',
            Severity: Major
            Found in Application/Contact/Phone/Frontend.php and 1 other location - About 1 hr to fix
            Application/Contact/Phone/Frontend.php on lines 374..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                if ($tblRelationshipPhoneAll) {
                        foreach ($tblRelationshipPhoneAll as $tblToPerson) {
                            if (($tblPhone = $tblToPerson->getTblPhone())) {
                                if ($tblToPerson->getTblType()->getName() == 'Notfall') {
                                    $phoneEmergencyList[$tblPhone->getId()][$tblToPerson->getTblType()->getId()][$tblPersonRelationship->getId()] = $tblToPerson;
            Severity: Minor
            Found in Application/Contact/Phone/Frontend.php and 1 other location - About 55 mins to fix
            Application/Contact/Phone/Frontend.php on lines 179..189

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (($tblPhoneList = Phone::useService()->getPhoneAllByPerson($tblPerson))){
            foreach ($tblPhoneList as $tblToPerson) {
                if (($tblPhone = $tblToPerson->getTblPhone())) {
                    if ($tblToPerson->getTblType()->getName() == 'Notfall') {
                        $phoneEmergencyList[$tblPhone->getId()][$tblToPerson->getTblType()->getId()][$tblPerson->getId()] = $tblToPerson;
            Severity: Minor
            Found in Application/Contact/Phone/Frontend.php and 1 other location - About 55 mins to fix
            Application/Contact/Phone/Frontend.php on lines 200..210

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status