Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Corporation/Company/Frontend.php

Summary

Maintainability
F
3 days
Test Coverage

Method frontendContact has 235 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendContact($Id = null, $Person = null, $Group = null, $tblPerson = null, $tblType = null, $tblSalutation = null, $doCreate = false)
    {
        $Stage = new Stage('Institution', 'Ansprechpartner');
        $Stage->addButton(new Standard('Zurück', '/Corporation/Company', new ChevronLeft(), array(
            'Id' => $Id,
Severity: Major
Found in Application/Corporation/Company/Frontend.php - About 1 day to fix

    Function frontendContact has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendContact($Id = null, $Person = null, $Group = null, $tblPerson = null, $tblType = null, $tblSalutation = null, $doCreate = false)
    {
        $Stage = new Stage('Institution', 'Ansprechpartner');
        $Stage->addButton(new Standard('Zurück', '/Corporation/Company', new ChevronLeft(), array(
            'Id' => $Id,
    Severity: Minor
    Found in Application/Corporation/Company/Frontend.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Frontend.php has 388 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Corporation\Company;

use SPHERE\Application\Corporation\Company\Service\Entity\ViewCompany;
use SPHERE\Application\Corporation\Group\Group;
    Severity: Minor
    Found in Application/Corporation/Company/Frontend.php - About 5 hrs to fix

      Method frontendDestroyCompany has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendDestroyCompany($Id = null, $Confirm = false, $Group = null)
    {

        $Stage = new Stage('Institution', 'Löschen');
        if ($Id) {
      Severity: Major
      Found in Application/Corporation/Company/Frontend.php - About 2 hrs to fix

        Function frontendDestroyCompany has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function frontendDestroyCompany($Id = null, $Confirm = false, $Group = null)
    {

        $Stage = new Stage('Institution', 'Löschen');
        if ($Id) {
        Severity: Minor
        Found in Application/Corporation/Company/Frontend.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method formContact has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function formContact()
    {
        $tblSalutationAll = Person::useService()->getSalutationAll();
        $tblRelationshipAll = Relationship::useService()->getTypeAllByGroup(
            Relationship::useService()->getGroupByIdentifier( 'COMPANY' )
        Severity: Minor
        Found in Application/Corporation/Company/Frontend.php - About 1 hr to fix

          Method frontendContact has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function frontendContact($Id = null, $Person = null, $Group = null, $tblPerson = null, $tblType = null, $tblSalutation = null, $doCreate = false)
          Severity: Major
          Found in Application/Corporation/Company/Frontend.php - About 50 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $Stage;
            Severity: Major
            Found in Application/Corporation/Company/Frontend.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (!$Confirm) {
                    $Stage->setContent(
                        new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(array(
                            new Panel('Institution', new Bold($tblCompany->getName().( $tblCompany->getDescription() !== '' ? '&nbsp;&nbsp;'
                                    . new Muted(new Small(new Small($tblCompany->getDescription()))) : '')),
              Severity: Major
              Found in Application/Corporation/Company/Frontend.php and 1 other location - About 1 hr to fix
              Application/People/Person/Frontend.php on lines 58..113

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status