Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Corporation/Company/FrontendReadOnly.php

Summary

Maintainability
D
2 days
Test Coverage

File FrontendReadOnly.php has 359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 17.12.2018
Severity: Minor
Found in Application/Corporation/Company/FrontendReadOnly.php - About 4 hrs to fix

    Method frontendCompanyReadOnly has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendCompanyReadOnly($Id = null, $Group = null)
    {

        $stage = new Stage('Institution', 'Datenblatt ' . ($Id ? 'bearbeiten' : 'anlegen'));
        $stage->addButton(new Standard('Zurück', '/Corporation/Search/Group', new ChevronLeft(), array('Id' => $Group)));
    Severity: Major
    Found in Application/Corporation/Company/FrontendReadOnly.php - About 3 hrs to fix

      Method getBasicFormRow has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getBasicFormRow()
    {
        $tblGroupList = Group::useService()->getGroupAll();
        if ($tblGroupList) {
            // Sort by Name
      Severity: Minor
      Found in Application/Corporation/Company/FrontendReadOnly.php - About 1 hr to fix

        Method getBasicContent has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function getBasicContent($CompanyId = null)
    {
        if (($tblCompany = Company::useService()->getCompanyById($CompanyId))) {
            $groups = array();
            if (($tblGroupList = Group::useService()->getGroupAllByCompany($tblCompany))) {
        Severity: Minor
        Found in Application/Corporation/Company/FrontendReadOnly.php - About 1 hr to fix

          Function getEditBasicContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getEditBasicContent($CompanyId = null)
    {

        $tblCompany = false;
        if ($CompanyId && ($tblCompany = Company::useService()->getCompanyById($CompanyId))) {
          Severity: Minor
          Found in Application/Corporation/Company/FrontendReadOnly.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkInputBasicContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function checkInputBasicContent(TblCompany $tblCompany = null, $Company)
    {
        $error = false;
        $form = $this->getEditBasicForm($tblCompany ? $tblCompany : null);
        if (isset($Company['Name']) && empty($Company['Name'])) {
          Severity: Minor
          Found in Application/Corporation/Company/FrontendReadOnly.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkInputCreateCompanyContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function checkInputCreateCompanyContent($Company)
    {
        $error = false;
        $form = $this->getCreateCompanyForm();
        if (isset($Company['Name']) && empty($Company['Name'])) {
          Severity: Minor
          Found in Application/Corporation/Company/FrontendReadOnly.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function frontendCompanyReadOnly has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendCompanyReadOnly($Id = null, $Group = null)
    {

        $stage = new Stage('Institution', 'Datenblatt ' . ($Id ? 'bearbeiten' : 'anlegen'));
        $stage->addButton(new Standard('Zurück', '/Corporation/Search/Group', new ChevronLeft(), array('Id' => $Group)));
          Severity: Minor
          Found in Application/Corporation/Company/FrontendReadOnly.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getBasicContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function getBasicContent($CompanyId = null)
    {
        if (($tblCompany = Company::useService()->getCompanyById($CompanyId))) {
            $groups = array();
            if (($tblGroupList = Group::useService()->getGroupAllByCompany($tblCompany))) {
          Severity: Minor
          Found in Application/Corporation/Company/FrontendReadOnly.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 13 locations. Consider refactoring.
          Open

                          new FormRow(array(
                    new FormColumn(array(
                        (new Primary('Speichern', ApiCompanyEdit::getEndpoint(), new Save()))
                            ->ajaxPipelineOnClick(ApiCompanyEdit::pipelineSaveBasicContent($tblCompany ? $tblCompany->getId() : 0)),
                        (new Primary('Abbrechen', ApiCompanyEdit::getEndpoint(), new Disable()))
          Severity: Major
          Found in Application/Corporation/Company/FrontendReadOnly.php and 12 other locations - About 1 hr to fix
          Application/People/Person/Frontend/FrontendBasic.php on lines 328..335
          Application/People/Person/Frontend/FrontendClub.php on lines 174..181
          Application/People/Person/Frontend/FrontendCommon.php on lines 220..227
          Application/People/Person/Frontend/FrontendCustody.php on lines 163..170
          Application/People/Person/Frontend/FrontendProspect.php on lines 254..261
          Application/People/Person/Frontend/FrontendStudent.php on lines 388..395
          Application/People/Person/Frontend/FrontendStudentGeneral.php on lines 417..424
          Application/People/Person/Frontend/FrontendStudentMedicalRecord.php on lines 177..184
          Application/People/Person/Frontend/FrontendStudentProcess.php on lines 419..426
          Application/People/Person/Frontend/FrontendStudentSubject.php on lines 319..326
          Application/People/Person/Frontend/FrontendStudentTransfer.php on lines 883..890
          Application/People/Person/Frontend/FrontendTeacher.php on lines 139..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              case 'COMMON':
                        $Global = $this->getGlobal();
                        $Global->POST['Company']['Group'][$tblGroup->getId()] = $tblGroup->getId();
                        $Global->savePost();
                        $tblGroup = new RadioBox(
          Severity: Major
          Found in Application/Corporation/Company/FrontendReadOnly.php and 1 other location - About 1 hr to fix
          Application/People/Person/Frontend/FrontendBasic.php on lines 356..365

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      $phoneContent = ApiPhoneToCompany::receiverModal()
                . TemplateReadOnly::getContent(
                    'Telefonnummern',
                    $phoneReceiver,
                    array(
          Severity: Major
          Found in Application/Corporation/Company/FrontendReadOnly.php and 3 other locations - About 1 hr to fix
          Application/Corporation/Company/FrontendReadOnly.php on lines 152..164
          Application/People/Person/FrontendReadOnly.php on lines 144..156
          Application/People/Person/FrontendReadOnly.php on lines 160..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      $mailContent = ApiMailToCompany::receiverModal()
                . TemplateReadOnly::getContent(
                    'E-Mail Adressen',
                    $mailReceiver,
                    array(
          Severity: Major
          Found in Application/Corporation/Company/FrontendReadOnly.php and 3 other locations - About 1 hr to fix
          Application/Corporation/Company/FrontendReadOnly.php on lines 136..148
          Application/People/Person/FrontendReadOnly.php on lines 144..156
          Application/People/Person/FrontendReadOnly.php on lines 160..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      $webContent = ApiWebToCompany::receiverModal()
                . TemplateReadOnly::getContent(
                    'Internet Adressen',
                    $webReceiver,
                    array(
          Severity: Major
          Found in Application/Corporation/Company/FrontendReadOnly.php and 2 other locations - About 1 hr to fix
          Application/Corporation/Company/FrontendReadOnly.php on lines 120..132
          Application/People/Person/FrontendReadOnly.php on lines 128..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      $addressContent = ApiAddressToCompany::receiverModal()
                . TemplateReadOnly::getContent(
                    'Adressdaten',
                    $addressToCompanyContent,
                    array(
          Severity: Major
          Found in Application/Corporation/Company/FrontendReadOnly.php and 2 other locations - About 1 hr to fix
          Application/Corporation/Company/FrontendReadOnly.php on lines 168..180
          Application/People/Person/FrontendReadOnly.php on lines 128..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private function getEditBasicTitle(TblCompany $tblCompany = null, $isCreateCompany = false)
    {
        return new Title(new Building() . ' ' . self::TITLE, 'der Institution'
            . ($tblCompany ? new Bold(new Success($tblCompany->getDisplayName())) : '')
            . ($isCreateCompany ? ' anlegen' : ' bearbeiten'));
          Severity: Minor
          Found in Application/Corporation/Company/FrontendReadOnly.php and 1 other location - About 30 mins to fix
          Application/People/Person/Frontend/FrontendBasic.php on lines 310..315

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status