Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Document/Custom/Zwickau/Zwickau.php

Summary

Maintainability
F
3 days
Test Coverage

Function frontendFillSchoolContract has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function frontendFillSchoolContract($PersonId = null)
    {

        $Stage = new Stage('Schulvertrag', 'Erstellen');
        $tblPerson = Person::useService()->getPersonById($PersonId);
Severity: Minor
Found in Application/Document/Custom/Zwickau/Zwickau.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method formStudentDocument has 117 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function formStudentDocument($Gender)
    {
//        $Data[] = 'BohrEy';

        return new Form(
Severity: Major
Found in Application/Document/Custom/Zwickau/Zwickau.php - About 4 hrs to fix

    File Zwickau.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Document\Custom\Zwickau;

use MOC\V\Core\FileSystem\FileSystem;
use SPHERE\Application\Contact\Address\Address;
    Severity: Minor
    Found in Application/Document/Custom/Zwickau/Zwickau.php - About 3 hrs to fix

      Method frontendFillSchoolContract has 83 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendFillSchoolContract($PersonId = null)
    {

        $Stage = new Stage('Schulvertrag', 'Erstellen');
        $tblPerson = Person::useService()->getPersonById($PersonId);
      Severity: Major
      Found in Application/Document/Custom/Zwickau/Zwickau.php - About 3 hrs to fix

        Method frontendSchoolContract has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function frontendSchoolContract()
    {

        $Stage = new Stage('Schulvertrag', 'Interessent auswählen');
        Severity: Minor
        Found in Application/Document/Custom/Zwickau/Zwickau.php - About 1 hr to fix

          Function frontendSchoolContract has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function frontendSchoolContract()
    {

        $Stage = new Stage('Schulvertrag', 'Interessent auswählen');
          Severity: Minor
          Found in Application/Document/Custom/Zwickau/Zwickau.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                              new LayoutColumn(new Well(
                                        new Layout(
                                            new LayoutGroup( array(
                                                new LayoutRow(array(
                                                    new LayoutColumn(
          Severity: Major
          Found in Application/Document/Custom/Zwickau/Zwickau.php and 1 other location - About 2 hrs to fix
          Application/Document/Custom/Zwickau/Zwickau.php on lines 345..361

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                              new LayoutColumn(new Well(
                                        new Layout(
                                            new LayoutGroup( array(
                                                new LayoutRow(array(
                                                    new LayoutColumn(
          Severity: Major
          Found in Application/Document/Custom/Zwickau/Zwickau.php and 1 other location - About 2 hrs to fix
          Application/Document/Custom/Zwickau/Zwickau.php on lines 328..344

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ($tblAddress) {
                $Global->POST['Data']['AddressStreet'] = $tblAddress->getStreetName().' '.$tblAddress->getStreetNumber();
                $tblCity = $tblAddress->getTblCity();
                if ($tblCity) {
                    $Global->POST['Data']['AddressPLZ'] = $tblCity->getCode();
          Severity: Major
          Found in Application/Document/Custom/Zwickau/Zwickau.php and 1 other location - About 1 hr to fix
          Application/Document/Standard/EnrollmentDocument/EnrollmentDocument.php on lines 231..239

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  $Stage->setContent(
            new Layout(
                new LayoutGroup(array(
                    new LayoutRow(
                        new LayoutColumn(
          Severity: Major
          Found in Application/Document/Custom/Zwickau/Zwickau.php and 4 other locations - About 1 hr to fix
          Application/Document/Standard/AccidentReport/AccidentReport.php on lines 420..442
          Application/Document/Standard/EnrollmentDocument/EnrollmentDocument.php on lines 252..274
          Application/Document/Standard/SignOutCertificate/SignOutCertificate.php on lines 270..292
          Application/Document/Standard/StudentTransfer/StudentTransfer.php on lines 349..371

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public static function registerModule()
    {
        Main::getDisplay()->addModuleNavigation(
            new Link(new Link\Route(__NAMESPACE__), new Link\Name('Schulvertrag'))
        );
          Severity: Major
          Found in Application/Document/Custom/Zwickau/Zwickau.php and 5 other locations - About 1 hr to fix
          Application/Document/Standard/AccidentReport/AccidentReport.php on lines 68..81
          Application/Document/Standard/EnrollmentDocument/EnrollmentDocument.php on lines 50..63
          Application/Document/Standard/SignOutCertificate/SignOutCertificate.php on lines 46..59
          Application/Document/Standard/StudentTransfer/StudentTransfer.php on lines 52..65
          Application/Platform/System/Session/Session.php on lines 42..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status