Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Document/Standard/StudentCard/Frontend.php

Summary

Maintainability
F
3 days
Test Coverage

Function frontendStudentCardSubjects has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

    public function frontendStudentCardSubjects($Id = null, $Data = null)
    {

        $Stage = new Stage('Schülerkartei Einstellungen', 'Fächer zuweisen');
        $Stage->addButton(new Standard(
Severity: Minor
Found in Application/Document/Standard/StudentCard/Frontend.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method frontendStudentCardSubjects has 125 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendStudentCardSubjects($Id = null, $Data = null)
    {

        $Stage = new Stage('Schülerkartei Einstellungen', 'Fächer zuweisen');
        $Stage->addButton(new Standard(
Severity: Major
Found in Application/Document/Standard/StudentCard/Frontend.php - About 5 hrs to fix

    File Frontend.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 27.04.2017
    Severity: Minor
    Found in Application/Document/Standard/StudentCard/Frontend.php - About 2 hrs to fix

      Method frontendSelectPerson has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function frontendSelectPerson()
    {

        $Stage = new Stage('Schülerkartei', 'Schüler auswählen');
        $Stage->addButton(new Standard('Einstellungen', '/Document/Standard/StudentCard/Setting', new CogWheels(),
      Severity: Major
      Found in Application/Document/Standard/StudentCard/Frontend.php - About 2 hrs to fix

        Method frontendSelectStudentCard has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendSelectStudentCard()
    {

        $Stage = new Stage('Schülerkartei Einstellungen', 'Schülerkartei auswählen');
        $Stage->addButton(new Standard(
        Severity: Minor
        Found in Application/Document/Standard/StudentCard/Frontend.php - About 1 hr to fix

          Function frontendSelectPerson has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function frontendSelectPerson()
    {

        $Stage = new Stage('Schülerkartei', 'Schüler auswählen');
        $Stage->addButton(new Standard('Einstellungen', '/Document/Standard/StudentCard/Setting', new CogWheels(),
          Severity: Minor
          Found in Application/Document/Standard/StudentCard/Frontend.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (strpos($tblDocument->getName(), 'Mittelschule') !== false){
                if (($tblSetting = Consumer::useService()->getSetting(
                        'Api',
                        'Education',
                        'Certificate',
          Severity: Major
          Found in Application/Document/Standard/StudentCard/Frontend.php and 1 other location - About 2 hrs to fix
          Application/Document/Standard/StudentCard/Frontend.php on lines 216..242

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      } elseif (strpos($tblDocument->getName(), 'Gymnasium') !== false){
                if (($tblSetting = Consumer::useService()->getSetting(
                        'Api',
                        'Education',
                        'Certificate',
          Severity: Major
          Found in Application/Document/Standard/StudentCard/Frontend.php and 1 other location - About 2 hrs to fix
          Application/Document/Standard/StudentCard/Frontend.php on lines 190..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status