Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Document/Standard/StudentTransfer/StudentTransfer.php

Summary

Maintainability
F
1 wk
Test Coverage

Function frontendFillStudentTransfer has a Cognitive Complexity of 167 (exceeds 5 allowed). Consider refactoring.
Open

    public function frontendFillStudentTransfer($Id = null)
    {

        $Stage = new Stage('Schülerüberweisung', 'Erstellen');
        $Stage->addButton(new Standard('Zurück', '/Document/Standard/StudentTransfer', new ChevronLeft()));
Severity: Minor
Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method frontendFillStudentTransfer has 189 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendFillStudentTransfer($Id = null)
    {

        $Stage = new Stage('Schülerüberweisung', 'Erstellen');
        $Stage->addButton(new Standard('Zurück', '/Document/Standard/StudentTransfer', new ChevronLeft()));
Severity: Major
Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 7 hrs to fix

    File StudentTransfer.php has 466 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace SPHERE\Application\Document\Standard\StudentTransfer;
    Severity: Minor
    Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 7 hrs to fix

      Method formStudentTransfer has 150 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function formStudentTransfer()
    {

        return new Form(
            new FormGroup(array(
      Severity: Major
      Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 6 hrs to fix

        Method frontendSelectPerson has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function frontendSelectPerson()
    {

        $Stage = new Stage('Schulbescheinigung', 'Schüler auswählen');
        Severity: Major
        Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 2 hrs to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ($tblAddressSchool) {
                            $Global->POST['Data']['AddressStreet'] = $tblAddressSchool->getStreetName().' '.$tblAddressSchool->getStreetNumber();
                            $tblCitySchool = $tblAddressSchool->getTblCity();
                            if ($tblCitySchool) {
                                $Global->POST['Data']['AddressCity'] = $tblCitySchool->getCode().', '.$tblCitySchool->getName();
          Severity: Major
          Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if ($tblYearList) {
                            foreach ($tblYearList as $tblYear) {
                                $tblDivision = Division::useService()->getDivisionByPersonAndYear($tblPerson, $tblYear);
                                if ($tblDivision && $tblDivision->getTblLevel()) {
                                    $Global->POST['Data']['SchoolEntryDivision'] = $tblDivision->getTblLevel()->getName();
            Severity: Major
            Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if ($tblToPersonList) {
                            foreach ($tblToPersonList as $tblToPerson) {
                                if ($tblType = $tblToPerson->getTblType()) {
                                    $TypeName = $tblType->getName();
                                    $TypeDescription = $tblType->getDescription();
              Severity: Major
              Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php - About 45 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public static function frontendSelectPerson()
    {

        $Stage = new Stage('Schulbescheinigung', 'Schüler auswählen');
                Severity: Major
                Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php and 2 other locations - About 2 days to fix
                Application/Document/Standard/AccidentReport/AccidentReport.php on lines 102..167
                Application/Document/Standard/SignOutCertificate/SignOutCertificate.php on lines 80..145

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 433.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                        if ($tblToPersonList) {
                            foreach ($tblToPersonList as $tblToPerson) {
                                if ($tblType = $tblToPerson->getTblType()) {
                                    $TypeName = $tblType->getName();
                                    $TypeDescription = $tblType->getDescription();
                Severity: Major
                Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php and 1 other location - About 6 hrs to fix
                Application/Document/Standard/AccidentReport/AccidentReport.php on lines 267..296

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 211.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                                if ($tblStudentTransfer) {
                    $EntryDate = $tblStudentTransfer->getTransferDate();
                    $Global->POST['Data']['SchoolEntry'] = $EntryDate;
                    if ($EntryDate != '') {
                        $tblYearList = Term::useService()->getYearAllByDate(new \DateTime($EntryDate));
                Severity: Major
                Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php and 2 other locations - About 2 hrs to fix
                Application/Document/Standard/AccidentReport/AccidentReport.php on lines 303..317
                Application/Document/Standard/SignOutCertificate/SignOutCertificate.php on lines 208..222

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 131.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                        $Stage->setContent(
            new Layout(
                new LayoutGroup(array(
                    new LayoutRow(
                        new LayoutColumn(
                Severity: Major
                Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php and 4 other locations - About 1 hr to fix
                Application/Document/Custom/Zwickau/Zwickau.php on lines 217..239
                Application/Document/Standard/AccidentReport/AccidentReport.php on lines 420..442
                Application/Document/Standard/EnrollmentDocument/EnrollmentDocument.php on lines 252..274
                Application/Document/Standard/SignOutCertificate/SignOutCertificate.php on lines 270..292

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                    public static function registerModule()
    {
        Main::getDisplay()->addModuleNavigation(
            new Link(new Link\Route(__NAMESPACE__), new Link\Name('Schülerüberweisung'))
        );
                Severity: Major
                Found in Application/Document/Standard/StudentTransfer/StudentTransfer.php and 5 other locations - About 1 hr to fix
                Application/Document/Custom/Zwickau/Zwickau.php on lines 48..61
                Application/Document/Standard/AccidentReport/AccidentReport.php on lines 68..81
                Application/Document/Standard/EnrollmentDocument/EnrollmentDocument.php on lines 50..63
                Application/Document/Standard/SignOutCertificate/SignOutCertificate.php on lines 46..59
                Application/Platform/System/Session/Session.php on lines 42..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 105.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status