Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Document/Storage/Service.php

Summary

Maintainability
D
1 day
Test Coverage

Function saveCertificateRevision has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function saveCertificateRevision(
        TblPerson $tblPerson,
        TblDivision $tblDivision,
        Certificate $Certificate,
        FilePointer $File,
Severity: Minor
Found in Application/Document/Storage/Service.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCertificateRevisionFileAllByPerson has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function getCertificateRevisionFileAllByPerson(TblPerson $tblPerson)
    {

        $tblPartition = $this->getPartitionByIdentifier(
            TblPartition::IDENTIFIER_CERTIFICATE_STORAGE
Severity: Minor
Found in Application/Document/Storage/Service.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Service has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class Service extends AbstractService
{

    /**
     * @param bool $doSimulation
Severity: Minor
Found in Application/Document/Storage/Service.php - About 2 hrs to fix

    Method saveCertificateRevision has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function saveCertificateRevision(
        TblPerson $tblPerson,
        TblDivision $tblDivision,
        Certificate $Certificate,
        FilePointer $File,
    Severity: Minor
    Found in Application/Document/Storage/Service.php - About 1 hr to fix

      Function getCertificateRevisionFileAll has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getCertificateRevisionFileAll()
    {
        $tblPartition = $this->getPartitionByIdentifier(
            TblPartition::IDENTIFIER_CERTIFICATE_STORAGE
        );
      Severity: Minor
      Found in Application/Document/Storage/Service.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              TblBinary $tblBinary,
        TblDirectory $tblDirectory,
        TblFileType $tblFileType,
        $Name,
        $Description = '',
      Severity: Minor
      Found in Application/Document/Storage/Service.php - About 45 mins to fix

        Method createDirectory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                TblPartition $tblPartition,
        $Name,
        $Description,
        TblDirectory $tblDirectory = null,
        $IsLocked = false,
        Severity: Minor
        Found in Application/Document/Storage/Service.php - About 45 mins to fix

          Method saveCertificateRevision has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  TblPerson $tblPerson,
        TblDivision $tblDivision,
        Certificate $Certificate,
        FilePointer $File,
        TblPrepareCertificate $tblPrepareCertificate = null
          Severity: Minor
          Found in Application/Document/Storage/Service.php - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status