Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Document/Storage/Service/Data.php

Summary

Maintainability
C
1 day
Test Coverage

Data has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class Data extends AbstractData
{

    /**
     * @return void
Severity: Minor
Found in Application/Document/Storage/Service/Data.php - About 2 hrs to fix

    File Data.php has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Document\Storage\Service;

use SPHERE\Application\Document\Storage\Service\Entity\TblBinary;
use SPHERE\Application\Document\Storage\Service\Entity\TblDirectory;
    Severity: Minor
    Found in Application/Document/Storage/Service/Data.php - About 2 hrs to fix

      Method createDirectory has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createDirectory(
        TblPartition $tblPartition,
        $Name,
        $Description,
        TblDirectory $tblDirectory = null,
      Severity: Minor
      Found in Application/Document/Storage/Service/Data.php - About 1 hr to fix

        Method createDirectory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                TblPartition $tblPartition,
        $Name,
        $Description,
        TblDirectory $tblDirectory = null,
        $IsLocked = false,
        Severity: Minor
        Found in Application/Document/Storage/Service/Data.php - About 45 mins to fix

          Method createFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  TblBinary $tblBinary,
        TblDirectory $tblDirectory,
        TblFileType $tblFileType,
        $Name,
        $Description = '',
          Severity: Minor
          Found in Application/Document/Storage/Service/Data.php - About 45 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    if (null === $Entity) {
            $Entity = new TblFile();
            $Entity->setTblBinary($tblBinary);
            $Entity->setTblDirectory($tblDirectory);
            $Entity->setTblFileType($tblFileType);
            Severity: Major
            Found in Application/Document/Storage/Service/Data.php and 3 other locations - About 50 mins to fix
            Application/Billing/Bookkeeping/Invoice/Service/Data.php on lines 472..484
            Application/Education/Certificate/Prepare/Service/Data.php on lines 470..487
            Application/People/Meta/Student/Service/Data/Subject.php on lines 208..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status