Function frontendSelectDivision
has a Cognitive Complexity of 144 (exceeds 5 allowed). Consider refactoring. Open
public function frontendSelectDivision($GenerateCertificateId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Klassen zuordnen');
$Stage->addButton(new Standard('Zurück', '/Education/Certificate/Generate', new ChevronLeft()));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File Frontend.php
has 1124 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: Kauschke
* Date: 23.11.2016
Function frontendDivision
has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring. Open
public function frontendDivision($GenerateCertificateId = null)
{
$Stage = new Stage('Zeugnis generieren', 'Klassenübersicht');
$Stage->addButton(new Standard('Zurück', '/Education/Certificate/Generate', new ChevronLeft()));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function frontendSelectTemplate
has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring. Open
public function frontendSelectTemplate($PrepareId = null, $DivisionId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Zeugnisvorlagen auswählen');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function formGenerate
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
private function formGenerate(TblYear $tblYear = null)
{
$certificateTypeList = array();
$tblCertificateTypeAll = Generator::useService()->getCertificateTypeAll();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method frontendSelectDivision
has 171 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendSelectDivision($GenerateCertificateId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Klassen zuordnen');
$Stage->addButton(new Standard('Zurück', '/Education/Certificate/Generate', new ChevronLeft()));
Method frontendDivision
has 167 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendDivision($GenerateCertificateId = null)
{
$Stage = new Stage('Zeugnis generieren', 'Klassenübersicht');
$Stage->addButton(new Standard('Zurück', '/Education/Certificate/Generate', new ChevronLeft()));
Method frontendSelectTemplate
has 157 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendSelectTemplate($PrepareId = null, $DivisionId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Zeugnisvorlagen auswählen');
Function frontendDestroyGenerate
has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring. Open
public function frontendDestroyGenerate($Id = null, $Confirm = false)
{
$Stage = new Stage('Zeugnisgenerierung', 'Löschen');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method formGenerate
has 118 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function formGenerate(TblYear $tblYear = null)
{
$certificateTypeList = array();
$tblCertificateTypeAll = Generator::useService()->getCertificateTypeAll();
Method frontendGenerate
has 117 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendGenerate($IsAllYears = false, $YearId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Übersicht');
Method frontendDestroyGenerate
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendDestroyGenerate($Id = null, $Confirm = false)
{
$Stage = new Stage('Zeugnisgenerierung', 'Löschen');
Method frontendGenerateSetting
has 76 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendGenerateSetting($GenerateCertificateId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Zusätzliche Einstellungen');
$Stage->addButton(new Standard('Zurück', '/Education/Certificate/Generate', new ChevronLeft()));
Method frontendEditGenerate
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frontendEditGenerate($Id = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Bearbeiten');
$Stage->setMessage('Die Notenaufträge können nur geändert werden bis ein Zeugnis freigeben wurde.');
Function frontendEditGenerate
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
public function frontendEditGenerate($Id = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Bearbeiten');
$Stage->setMessage('Die Notenaufträge können nur geändert werden bis ein Zeugnis freigeben wurde.');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method formEditGenerate
has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function formEditGenerate(TblYear $tblYear = null, $IsLocked)
{
$tblAppointedDateTaskListByYear = Evaluation::useService()->getTaskAllByTestType(
Function frontendGenerate
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function frontendGenerate($IsAllYears = false, $YearId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Übersicht');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function frontendGenerateSetting
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function frontendGenerateSetting($GenerateCertificateId = null, $Data = null)
{
$Stage = new Stage('Zeugnis generieren', 'Zusätzliche Einstellungen');
$Stage->addButton(new Standard('Zurück', '/Education/Certificate/Generate', new ChevronLeft()));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if ($tblFirstPeriod->getId() == $tblCurrentPeriod->getId()) {
$Global->POST['Data']['Type'] = Generator::useService()->getCertificateTypeByIdentifier('HALF_YEAR');
} elseif ($tblSecondPeriod->getId() == $tblCurrentPeriod->getId()) {
$Global->POST['Data']['Type'] = Generator::useService()->getCertificateTypeByIdentifier('YEAR');
}
Avoid deeply nested control flow statements. Open
if ($fromDate <= $now && $now <= $toDate) {
$tblCurrentPeriod = $tblPeriod;
break;
}
Avoid deeply nested control flow statements. Open
if ($type->getName() == 'Gymnasium'
&& (($tblLevel = $tblDivision->getTblLevel()))
&& $tblLevel->getName() == '12'
) {
$schoolTypeList[$type->getId()][$tblDivision->getId()] = $tblDivision->getDisplayName();
Avoid deeply nested control flow statements. Open
if ($type->getName() == 'Gymnasium'
&& (($tblLevel = $tblDivision->getTblLevel()))
&& ($tblLevel->getName() == '11' || $tblLevel->getName() == '12')
) {
$schoolTypeList[$type->getId()][$tblDivision->getId()] = $tblDivision->getDisplayName();
Avoid deeply nested control flow statements. Open
if ($tblCertificateType->getIdentifier() != 'GRADE_INFORMATION'
&& $type->getName() == 'Gymnasium'
&& (($tblLevel = $tblDivision->getTblLevel()))
&& ($tblLevel->getName() == '11' || $tblLevel->getName() == '12')
) {
Avoid deeply nested control flow statements. Open
if (($tblStudent = Student::useService()->getStudentByPerson($tblPerson))
&& ($tblTransferType = Student::useService()->getStudentTransferTypeByIdentifier('PROCESS'))
&& ($tblStudentTransfer = Student::useService()->getStudentTransferByType($tblStudent,
$tblTransferType))
&& ($tblCourse = $tblStudentTransfer->getServiceTblCourse())
Consider simplifying this complex logical expression. Open
if ($type->getName() == 'Gymnasium'
&& (($tblLevel = $tblDivision->getTblLevel()))
&& $tblLevel->getName() == '12'
) {
$schoolTypeList[$type->getId()][$tblDivision->getId()] = $tblDivision->getDisplayName();
Identical blocks of code found in 2 locations. Consider refactoring. Open
new LayoutGroup(array(
new LayoutRow(array(
new LayoutColumn(array(
new Panel('Zeugnisdatum', $tblGenerateCertificate->getDate(), Panel::PANEL_TYPE_INFO)
), 3),
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 202.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
new LayoutGroup(array(
new LayoutRow(array(
new LayoutColumn(array(
new Panel('Zeugnisdatum', $tblGenerateCertificate->getDate(), Panel::PANEL_TYPE_INFO)
), 3),
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 202.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
new FormColumn(
new Panel(
'Unterzeichner',
array(
(new CheckBox('Data[IsTeacherAvailable]',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 174.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
new FormColumn(
new Panel(
'Unterzeichner',
array(
new CheckBox('Data[IsTeacherAvailable]',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 174.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (!$Confirm) {
$divisionList = array();
$divisionList[0] = 'Zeungisdatum: ' . $tblGenerateCertificate->getDate();
$divisionList[1] = 'Typ: ' . (($tblCertificateType = $tblGenerateCertificate->getServiceTblCertificateType())
? $tblCertificateType->getName() : '');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 128.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
(new Standard(
'', '/Education/Certificate/Generate/Edit', new Edit(),
array(
'Id' => $tblGenerateCertificate->getId(),
)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 106.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76